Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[other] ENGMT-1985: updates to api connectivity #1094

Merged
merged 1 commit into from
Dec 11, 2024
Merged

Conversation

bredmond5
Copy link
Contributor

Pull Request Template

Description

  • Gives some predefined options for stage, stage_ac, prod, prod_ac like the android and ios mobile apps
  • Gives the option to specify your own endpoint
  • Switches the default branch key for staging to the ones we are using for the mobile apps
  • Adds an error message if branch.init fails
Screenshot 2024-12-11 at 1 30 18 PM

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Unit test
  • Integration test

JS Budget Check

Please mention the size in kb before abd after this PR

Files Before After
dist/build.js.
dist/build.min.js

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

Mentions:

List the person or team responsible for reviewing proposed changes.

cc @BranchMetrics/saas-sdk-devs for visibility.

Gives some predefined options for stage, stage_ac, prod, prod_ac like the android and ios mobile apps

Gives the option to specify your own endpoint

Switches the default branch key for staging to the ones we are using for the mobile apps

Adds an error message if branch.init fails
Copy link
Contributor

Test Results

  1 files  ±0    1 suites  ±0   54s ⏱️ +3s
159 tests ±0  152 ✅ ±0  7 💤 ±0  0 ❌ ±0 
162 runs  ±0  155 ✅ ±0  7 💤 ±0  0 ❌ ±0 

Results for commit 5feca72. ± Comparison against base commit eb97ada.

@bredmond5 bredmond5 merged commit 7b5b77c into master Dec 11, 2024
5 checks passed
@bredmond5 bredmond5 deleted the ENGMT-1985 branch December 11, 2024 23:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants