Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): send session_link_click_id #930

Merged
merged 1 commit into from
Sep 11, 2023

Conversation

JagadeeshKaricherla-branch
Copy link
Contributor

@JagadeeshKaricherla-branch JagadeeshKaricherla-branch commented Sep 11, 2023

receive and send session_link_click_id

Pull Request Template

Description

  • SDK-2113 : save session_link_click_id received from /open to storage and send it as a request param to v1/pageview
  • cleanup example.html of deprecated methods

Fixes # (issue) : SDK-2113

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Unit test
  • Integration test

JS Budget Check

Please mention the size in kb before abd after this PR

Files Before After
dist/build.js.
dist/build.min.js

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

Mentions:

List the person or team responsible for reviewing proposed changes.

cc @BranchMetrics/saas-sdk-devs for visibility.

receive and send session_referring_link_data
@github-actions
Copy link
Contributor

github-actions bot commented Sep 11, 2023

Test Results

112 tests   105 ✔️  1m 1s ⏱️
    1 suites      7 💤
    1 files        0

Results for commit a452ace.

♻️ This comment has been updated with latest results.

@codecov
Copy link

codecov bot commented Sep 11, 2023

Codecov Report

❗ No coverage uploaded for pull request base (master@70c90a1). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master     #930   +/-   ##
=========================================
  Coverage          ?   24.59%           
=========================================
  Files             ?       15           
  Lines             ?     2322           
  Branches          ?        0           
=========================================
  Hits              ?      571           
  Misses            ?     1751           
  Partials          ?        0           

@JagadeeshKaricherla-branch JagadeeshKaricherla-branch merged commit 802e68a into master Sep 11, 2023
@JagadeeshKaricherla-branch JagadeeshKaricherla-branch deleted the feature/session_link_click_id branch September 11, 2023 23:53
@JagadeeshKaricherla-branch JagadeeshKaricherla-branch changed the title feat(core): send session_referring_link_data feat(core): send session_link_click_id Sep 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants