Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependabot-merger to tag on-call engineer #946

Merged
merged 1 commit into from
Oct 10, 2023

Conversation

nsingh-branch
Copy link
Contributor

Description

Updated the GHA to also get the current on-call engineer and tag them in the Slack message.

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Ran with Act locally.

  • Unit test
  • Integration test

JS Budget Check

Please mention the size in kb before abd after this PR

Files Before After
dist/build.js.
dist/build.min.js

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

Mentions:

List the person or team responsible for reviewing proposed changes.

cc @BranchMetrics/saas-sdk-devs for visibility.

@github-actions
Copy link
Contributor

Test Results

112 tests   105 ✔️  55s ⏱️
    1 suites      7 💤
    1 files        0

Results for commit 52f713f.

@codecov
Copy link

codecov bot commented Oct 10, 2023

Codecov Report

❗ No coverage uploaded for pull request base (master@9da1bbe). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master     #946   +/-   ##
=========================================
  Coverage          ?   24.59%           
=========================================
  Files             ?       15           
  Lines             ?     2322           
  Branches          ?        0           
=========================================
  Hits              ?      571           
  Misses            ?     1751           
  Partials          ?        0           

@JagadeeshKaricherla-branch JagadeeshKaricherla-branch merged commit 6fb67ea into master Oct 10, 2023
7 checks passed
@JagadeeshKaricherla-branch JagadeeshKaricherla-branch deleted the fix-dependabot-merger branch October 10, 2023 22:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants