Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature deprecation/banner #963

Merged
merged 2 commits into from
Dec 7, 2023
Merged

Feature deprecation/banner #963

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ff034d6
feat(core): add deprecation warning for Branch.banner method
JagadeeshKaricherla-branch Dec 7, 2023
e165a77
ci(core): fix eof for package.json
JagadeeshKaricherla-branch Dec 7, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
140 changes: 73 additions & 67 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,69 +1,75 @@
{
"name": "branch-sdk",
"version": "2.80.0",
"description": "Branch Metrics Deep Linking/Smart Banner Web SDK",
"main": "dist/build.min.js",
"files": [
"dist/build.min.js"
],
"scripts": {
"build": "make",
"ci": "npm ci",
"clean": "npm-run-all clean:*",
"clean:dist": "rimraf dist/*",
"clean:coverage": "rimraf .nyc_output coverage",
"clean:test-report": "rimraf test-results.json",
"clean-and-develop": "npm-run-all ci clean build cover",
"commit": "git-cz",
"cover": "npm-run-all cover:*",
"cover:clean": "npm run clean:coverage",
"cover:report": "npx nyc@latest mocha",
"lint": "./lint.sh",
"test": "mocha",
"test-report": "mocha --reporter json > test-results.json",
"builddocs": "jsdox src/3_branch_web.js --output docs/web",
"prepare": "husky install"
},
"repository": {
"type": "git",
"url": "https://github.com/BranchMetrics/web-branch-deep-linking-attribution.git"
},
"author": "Dmitri Gaskin <[email protected]>",
"contributors": [
"Jagadeesh Karicherla"
],
"license": "MIT",
"bugs": {
"url": "https://github.com/BranchMetrics/web-branch-deep-linking-attribution/issues",
"email": "[email protected]"
},
"homepage": "https://help.branch.io/developers-hub/docs/web-sdk-overview",
"devDependencies": {
"commitizen": "^4.3.0",
"cz-customizable": "^7.0.0",
"falafel": "2.2.5",
"google-closure-compiler": "^20230802.0.0",
"google-closure-deps": "^20230802.0.0",
"google-closure-library": "^20230802.0.0",
"husky": "^8.0.0",
"i": "^0.3.7",
"jscs": "2.0.0",
"jsdom": "21.1.0",
"jsdom-global": "3.0.2",
"jshint": "^2.13.6",
"mocha": "^10.2.0",
"npm-run-all": "^4.1.5",
"precommit-hook": "3.0.0",
"rimraf": "^5.0.1",
"sinon": "16.0.0"
},
"build": "2.71.0",
"config": {
"commitizen": {
"path": "./node_modules/cz-customizable"
},
"cz-customizable": {
"config": ".cz-config.js"
}
}
"name": "branch-sdk",
"version": "2.80.0",
"description": "Branch Metrics Deep Linking/Smart Banner Web SDK",
"main": "dist/build.min.js",
"files": [
"dist/build.min.js"
],
"scripts": {
"build": "make",
"ci": "npm ci",
"clean": "npm-run-all clean:*",
"clean:dist": "rimraf dist/*",
"clean:coverage": "rimraf .nyc_output coverage",
"clean:test-report": "rimraf test-results.json",
"clean-and-develop": "npm-run-all ci clean build cover",
"commit": "git-cz",
"cover": "npm-run-all cover:*",
"cover:clean": "npm run clean:coverage",
"cover:report": "npx nyc@latest mocha",
"lint": "./lint.sh",
"test": "mocha",
"test-report": "mocha --reporter json > test-results.json",
"builddocs": "jsdox src/3_branch_web.js --output docs/web",
"prepare": "husky install",
"validate": "npm ls"
},
"repository": {
"type": "git",
"url": "https://github.com/BranchMetrics/web-branch-deep-linking-attribution.git"
},
"author": "Dmitri Gaskin <[email protected]>",
"contributors": [
"Jagadeesh Karicherla"
],
"license": "MIT",
"bugs": {
"url": "https://github.com/BranchMetrics/web-branch-deep-linking-attribution/issues",
"email": "[email protected]"
},
"homepage": "https://help.branch.io/developers-hub/docs/web-sdk-overview",
"devDependencies": {
"commitizen": "^4.3.0",
"cz-customizable": "^7.0.0",
"falafel": "2.2.5",
"google-closure-compiler": "^20230802.0.0",
"google-closure-deps": "^20230802.0.0",
"google-closure-library": "^20230802.0.0",
"husky": "^8.0.0",
"i": "^0.3.7",
"jscs": "2.0.0",
"jsdom": "21.1.0",
"jsdom-global": "3.0.2",
"jshint": "^2.13.6",
"mocha": "^10.2.0",
"npm-run-all": "^4.1.5",
"precommit-hook": "3.0.0",
"rimraf": "^5.0.1",
"sinon": "16.0.0"
},
"build": "2.71.0",
"config": {
"commitizen": {
"path": "./node_modules/cz-customizable"
},
"cz-customizable": {
"config": ".cz-config.js"
}
},
"pre-commit": [
"lint",
"validate",
"test"
]
}
1 change: 1 addition & 0 deletions src/6_branch.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1683,6 +1683,7 @@ Branch.prototype['closeJourney'] = wrap(callback_params.CALLBACK_ERR, function(d
});

Branch.prototype['banner'] = wrap(callback_params.CALLBACK_ERR, function(done, options, data) {
console.warn('The "banner" method is deprecated and will be removed in future versions. Please use Branch Journeys instead. For more information and migration steps, visit: https://help.branch.io/using-branch/docs/journeys-overview');
if (!utils.mobileUserAgent()) {
console.info("banner functionality is not supported on desktop");
}
Expand Down
Loading