Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat lp locking #141

Merged
merged 102 commits into from
Dec 2, 2024
Merged

Feat lp locking #141

merged 102 commits into from
Dec 2, 2024

Conversation

subject026
Copy link
Member

No description provided.

Copy link
Contributor

@secbajor secbajor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great! there is a lot here. I gave this a quick review and dropped a few quick comments, writing a bit more below as items that we can sync on when we have our next call.

i checked this out locally and rebased it with the latest on dev/main -- there will be a few conflicts we have to make sure to resolve; mostly with the Bread/Power Icons

I'm also noticing that currently with this PR i am seeing the link to lp token locking, so just noting that we need to check for the feature flag being enabled in at least one more place.

i am seeing an opportunity to potentially refactor the useVotingPower context so that it could accept any wallet address, in this way we could use it to fetch both the logged in user voting power and a project's voting power, but this could happen later/separately.

src/app/bakery/components/Swap/Bake.tsx Show resolved Hide resolved
src/app/core/components/Icons/FistIcon.tsx Show resolved Hide resolved
src/app/governance/context/VotingPowerContext.tsx Outdated Show resolved Hide resolved
src/app/governance/lp-vaults/page.tsx Outdated Show resolved Hide resolved
@secbajor secbajor marked this pull request as ready for review November 26, 2024 17:17
add extra context

separate files
add vp tooltip info

unused import
vp tooltiop info

add vp tooltip info

unused import

add vp tooltip info
Copy link

netlify bot commented Dec 2, 2024

Deploy Preview for breadchain-development ready!

Name Link
🔨 Latest commit 060f2a2
🔍 Latest deploy log https://app.netlify.com/sites/breadchain-development/deploys/674df9753a151a0008cb5f83
😎 Deploy Preview https://deploy-preview-141--breadchain-development.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@subject026 subject026 merged commit ec26082 into development Dec 2, 2024
6 checks passed
@subject026 subject026 deleted the feat-lp-locking branch December 2, 2024 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants