-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat lp locking #141
Feat lp locking #141
Conversation
c1322b87eea31f07fbda56b217cdca6ea5353b72
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
great! there is a lot here. I gave this a quick review and dropped a few quick comments, writing a bit more below as items that we can sync on when we have our next call.
i checked this out locally and rebased it with the latest on dev/main -- there will be a few conflicts we have to make sure to resolve; mostly with the Bread/Power Icons
I'm also noticing that currently with this PR i am seeing the link to lp token locking, so just noting that we need to check for the feature flag being enabled in at least one more place.
i am seeing an opportunity to potentially refactor the useVotingPower context so that it could accept any wallet address, in this way we could use it to fetch both the logged in user voting power and a project's voting power, but this could happen later/separately.
add extra context separate files
add vp tooltip info unused import
…ing-v2 into feat-lp-locking
vp tooltiop info add vp tooltip info unused import add vp tooltip info
…ing-v2 into feat-lp-locking
✅ Deploy Preview for breadchain-development ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
No description provided.