Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review #91

Open
wants to merge 9 commits into
base: cris_bridge
Choose a base branch
from

Conversation

Cristianetaniguti
Copy link
Collaborator

@Cristianetaniguti Cristianetaniguti commented Jan 6, 2025

CITATION file added in inst/
With that, the R function citation("BIGapp") works (update when published)
 
Convert to VCF

  • Remove defunct code for action button
  • Add missing input alert in the download button
     
    Dosage Calling
  • Add "Required" * symbol in all required inputs
  • I couldn't make the disable/enable for the download button work, therefore I changed it to a dynamic UI. Now, the download button will only appear if the analysis was run and met all requirements.
     
    VCF filtering
  • Same modification replacing the disable/enable button system by the renderUI
  • Highlight the "save image" button by adding text to icon
     
    Genomic Diversity
  • Round the table number for maximum 4 decimal numbers
  • Highlight the "save image" button by adding text to icon

PCA

  • BUG when group information was absent - exceptions added
  • Highlight the "save image" button by adding text to icon
  • There was a BUG if "run analysis" only with vcf file, and later adding the passport. The graphics were being updated without updating the dataset leading to an error. I added the new variable "pca_data$group_info" to make all variables in the graphics dependent of the data evaluation

DAPC

  • Highlight the "save image" button by adding text to icon
  • Remove nonfunctional code - STRUCTURE plot

Predictive Ability

  • Add "required" symbol * to inputs
  • Highlight the "save image" button by adding text to icon

 Genomic Prediction

  • Highlight the "save image" button by adding text to icon

@Cristianetaniguti Cristianetaniguti changed the title Review tabs 1-4 Review Jan 6, 2025
@Cristianetaniguti Cristianetaniguti added the work in progress More commits are coming label Jan 6, 2025
@Cristianetaniguti Cristianetaniguti removed the work in progress More commits are coming label Jan 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant