Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BI-1914 - Improve exp dataset sort #303

Merged
merged 11 commits into from
Nov 8, 2023
Merged

BI-1914 - Improve exp dataset sort #303

merged 11 commits into from
Nov 8, 2023

Conversation

davedrp
Copy link
Contributor

@davedrp davedrp commented Oct 17, 2023

Description

BI-1914 - Improve exp dataset sort

Added two methods to sort the dataset:

  • sortDefaultForObservationUnit() - called by getDatasetData() to sort the datset as displayed on the Experiment detail page.
  • sortDefaultForExportRows() - called by exportObservations() to sort the dataset for the Experiment download.

ALSO
The sheet-name of an downloaded Excel experiment is now "Data" instead of "Experiment Data" see BI-1583

Dependencies

bi-web: feature/BI-1914 branch

Testing

  • go to the Experiment detail page

  • the default order should be by Env and then Exp Unit Id

  • Download an experiment

  • the order of the downloaded file(s) should be by Env and then Exp Unit Id

Checklist:

  • I have performed a self-review of my own code
  • I have tested my code and ensured it meets the acceptance criteria of the story
  • I have tested that my code works with both the brapi-java-server and BreedBase
  • I have create/modified unit tests to cover this change
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to documentation
  • I have run TAF: <please include a link to TAF run>

@davedrp davedrp requested review from a team, timparsons and dmeidlin and removed request for a team October 17, 2023 12:48
@davedrp davedrp marked this pull request as ready for review November 2, 2023 20:35
@davedrp davedrp merged commit 2eb843e into develop Nov 8, 2023
1 check passed
@davedrp davedrp deleted the feature/BI-1914 branch November 8, 2023 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants