Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BI-1911 fix QA findings #304

Merged
merged 2 commits into from
Oct 30, 2023
Merged

BI-1911 fix QA findings #304

merged 2 commits into from
Oct 30, 2023

Conversation

davedrp
Copy link
Contributor

@davedrp davedrp commented Oct 20, 2023

D# Description

BI-1911 - in response to Shahana's testing notes.

Dependencies

bi-api: bug/BI-1911-2 branch

Testing

  • Import an Experiment.
  • Look at the confirmation page.

Expected Results

  • The Env Year, Env, and Exp unit ID columns should appear as they did in the import file.

Checklist:

  • I have performed a self-review of my own code
  • I have tested my code and ensured it meets the acceptance criteria of the story
  • I have create/modified unit tests to cover this change
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to documentation
  • I have run TAF: <link to TAF run>

BI-1911 - in response to Shahana's testing notes.

Dependencies

bi-web: bug/BI-1911-2 branch

Testing

  • Import an Experiment.
  • Look at the confirmation page.

Expected Results

  • The Env Year, Env, and Exp unit ID columns should appear as they did in the import file.

Checklist:

  • I have performed a self-review of my own code
  • I have tested my code and ensured it meets the acceptance criteria of the story
  • I have create/modified unit tests to cover this change
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to documentation
  • I have run TAF: <link to TAF run>

@davedrp davedrp requested review from timparsons and mlm483 October 20, 2023 16:11
@github-actions github-actions bot added the bug Something isn't working label Oct 20, 2023
@davedrp davedrp marked this pull request as ready for review October 20, 2023 16:12
mlm483
mlm483 requested changes Oct 20, 2023
View reviewed changes
Copy link
Contributor

@mlm483 mlm483 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functionality looks good, I would make this change: Breeding-Insight/bi-web#341 (comment)

@davedrp
Copy link
Contributor Author

davedrp commented Oct 30, 2023

A new story to address the comment from MLM483 has been written.

@davedrp davedrp requested a review from mlm483 October 30, 2023 13:45
@davedrp davedrp merged commit f3545f1 into release/0.8.1 Oct 30, 2023
2 checks passed
@davedrp davedrp deleted the bug/BI-1911-2 branch October 30, 2023 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mlm483 mlm483 mlm483 approved these changes

@timparsons timparsons timparsons approved these changes

Assignees

@timparsons timparsons

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@davedrp @timparsons @mlm483