BI-1910 - Allow Breeder to Upload a Genotype Sample File #306
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timparsons
requested review from
a team,
davedrp and
nickpalladino
and removed request for
a team
| var legalGermplasmName = germplasm.getDefaultDisplayName().replaceAll(SAMPLE_NAME_ILLEGAL_CHARS_REGEX, "_"); | ||
| String name = String.format(SAMPLE_NAME_FORMAT, legalGermplasmName, plate.getPlateName(), row, Integer.parseInt(column)); | ||
|
|
||
| if(name.length() > 100) { |
There was a problem hiding this comment.
What's the significance of length 100?
There was a problem hiding this comment.
@nickpalladino This is a DArT restriction
| @Client("/${micronaut.bi.api.version}") | ||
| private RxHttpClient client; | ||
|
|
||
| // private final Gson gson = new GsonBuilder().registerTypeAdapter(OffsetDateTime.class, (JsonDeserializer<OffsetDateTime>) |
timparsons
force-pushed
the
feature/BI-1910
branch
from
014890e to
25d77d3
Compare
nickpalladino
approved these changes
Nov 27, 2023
davedrp
approved these changes
Nov 29, 2023
…atch the object type being saved
…ssions Able to fetch submissions. Able to generate a DArT submission file. Able to submit them via BrAPI to a vendor. Able to update the status. Able to automatically check the status of a submission.
timparsons
force-pushed
the
feature/BI-1910
branch
from
25d77d3 to
7ae9224
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Story: https://breedinginsight.atlassian.net/browse/BI-1910
Defined new endpoints for creating and managing sample submissions including:
Dependencies
Testing
See testing instructions in Breeding-Insight/bi-web#343
Checklist: