[BI-2355] - Non-informative error message: regression

[HMS17]

Closed due to messy commit list

Description

Story: BI-2355 - Non-informative error message: regression

This error was due to tablesaw processing brackets weirdly, resulting in the column name stored in data not matching the column name stored in dynamic column names. This was fixed in two parts:

1. Removing brackets from ontology term names on upload

2. Preventing ontology terms with brackets in the name from being created by extending the functionality created in BI-2328

Note that this means for the error message re ontology terms not found, periods and brackets will be removed from the invalid ontology term names

Dependencies

n/a

Testing

Test that on upload of an experiment file with invalid ontology term columns headings that contain brackets and/or periods that the unknown error message no longer shows and instead the invalid ontology term message shows

Test that upload of experiment file with valid ontology terms proceeds as expected

Test that the appropriate error is thrown when an ontology term contains ".", "[" and/or "]" and that that error is not thrown when the ontology term does not contain those characters for:

• Ontology Term Creation in UI
• Ontology Term Edit
• Ontology Term File Upload

Checklist:

• I have performed a self-review of my own code
• I have tested my code and ensured it meets the acceptance criteria of the story
• I have tested that my code works with both the brapi-java-server and BreedBase
• I have create/modified unit tests to cover this change
• I have commented my code, particularly in hard-to-understand areas
• I have made corresponding changes to documentation
• I have run TAF: <please include a link to TAF run>