-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BI-2376 - Create Delete Endpoint for Deltabreed Experiment Controller #437
Open
mlm483
wants to merge
16
commits into
develop
Choose a base branch
from
feature/BI-2376
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Story: BI-2376
This feature adds a delete endpoint for experiments to bi-api. The endpoint is capable of requesting a hard or soft delete of the backing brapi service, but if an experiment has observations and a hard delete is requested, nothing will be deleted and a 409 Conflict response will be returned.
Additional features:
BrAPIListDAO::deleteBrAPIList
method to delete all lists along with the experiment.Dependencies
Now that Breeding-Insight/brapi-Java-TestServer#41 has been merged, the delete endpoints are present in the
develop
tagged brapi-server docker image. You may need to manually rundocker pull breedinginsight/brapi-java-server:develop
to update your local image, and you'll certainly need to delete and recreate your local brapi-serve container to use the updated image.Testing
Use an API client to test the following 4 Cases.
The endpoint will be the following (substitute your programId, experimentId and hardDelete values.
http://localhost:8081/v1/programs/{{programId}}/experiments/{{experimentId}}?hard={{hardDelete}}
Checklist: