Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BI-2047 - Pull Existing Observation Values For An Experiment Into Field-Book #443

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from

Conversation

mlm483
Copy link
Contributor

@mlm483 mlm483 commented Feb 11, 2025

Description

Story: BI-2047

Partially implemented the BrAPI /observations GET endpoint to support pulling existing observation values into Field Book.

There is a story to add support for all query params, BI-2506.

Testing

Part 1: Field Book Integration

To test with Delta Breed running locally and Field Book running in an android emulator, follow the Connect to Local DeltaBreed from Field Book section of the Field Book Development Guide.

  1. Upload an experiment with observations to DeltaBreed.
  2. Pull the experiment into Field Book (I recommend enabling the new BrAPI import UI in Settings > Experimental.
  3. On the Field Book "Field Detail" page, use the "Sync" activity to pull existing observations into Field Book.
  4. The data collected should be visualized in the "Data" section of the "Field Detail" page.
  5. Go to the "Collect" activity, and confirm that the values uploaded to DeltaBreed are in the Field Book collection UI.

Part 2: 501 Not Implemented

  • Using the /observations GET endpoint with query parameters other than studyDbId should result in a 501 status code.

For example a request to {{baseURL}}/v1/programs/{{programId}}/brapi/v2/observations?trialDbId={{trialDbId}} with all variables substituted with valid values should result in a 501 response. The story to implement support other query parameters is BI-2506.

Checklist:

  • I have performed a self-review of my own code
  • I have tested my code and ensured it meets the acceptance criteria of the story
  • I have tested that my code works with both the brapi-java-server and BreedBase
  • I have create/modified unit tests to cover this change
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to documentation
  • I have run TAF: <please include a link to TAF run>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant