Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BI-2355] - Non-informative error message: regression #412

Merged
merged 1 commit into from
Nov 1, 2024

Conversation

HMS17
Copy link
Contributor

@HMS17 HMS17 commented Oct 31, 2024

Description

Story: BI-2355 - Non-informative error message: regression

This error was due to tablesaw processing brackets weirdly, resulting in the column name stored in data not matching the column name stored in dynamic column names.

This part of the fix links to a new ontology import template that clarifies that brackets are invalid for ontology term name.

Dependencies

bi-api: bug/BI-2355.2

Testing

Download ontology import template and ensure it mentions that brackets along with periods are invalid for ontology term name.

Checklist:

  • I have performed a self-review of my own code
  • I have tested my code and ensured it meets the acceptance criteria of the story
  • I have create/modified unit tests to cover this change
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to documentation
  • I have run TAF: <link to TAF run>

@github-actions github-actions bot added the bug Something isn't working label Oct 31, 2024
@HMS17 HMS17 marked this pull request as ready for review October 31, 2024 20:09
@HMS17 HMS17 requested review from davedrp, mlm483 and dmeidlin and removed request for davedrp October 31, 2024 20:10
@mlm483 mlm483 self-assigned this Nov 1, 2024
Copy link
Contributor

@mlm483 mlm483 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested, working. The new template, bi_ontology_template_v16_2024-10-31.xls, downloaded as expected.

@HMS17 HMS17 merged commit 1471454 into release/1.0 Nov 1, 2024
2 checks passed
@HMS17 HMS17 deleted the bug/BI-2355.2 branch November 1, 2024 21:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants