Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BI-2343] - GID filtering not informative #418

Merged
merged 1 commit into from
Nov 27, 2024
Merged

[BI-2343] - GID filtering not informative #418

merged 1 commit into from
Nov 27, 2024

Conversation

HMS17
Copy link
Contributor

@HMS17 HMS17 commented Nov 15, 2024

Description

Story: BI-2343 - GID filtering not informative

Changes to enable exact match GID filtering for multiple tables

For Experiment Details and Sample Submission Details tables, frontend search is used, so a custom-search function was added in the respective buefy files to do exact search filtering in the GID case.

For Germplasm and Germplasm list tables, backend search is used, which presently only does partial matching. Due to the high risk associated with modifying backend search to alternatively enable exact or partial match for each filter, ResponseUtils:search was slightly modified to do an exact match specifically when the filter is accessionNumber.

Dependencies

bi-api: bug/BI-2343

Testing

On the following table components:

  • All Germplasm
  • Germplasm List Details
  • Experiment Details
  • Sample Submission Details

Enter multiple different values into GID to ensure that the results are filtered by exact match
Enter values into GID and other columns to ensure that results are correctly filtered by multiple columns
Check that pagination is still working correctly with GID filtering by filtering by a value that exists through multiple pages

Checklist:

  • I have performed a self-review of my own code
  • I have tested my code and ensured it meets the acceptance criteria of the story
  • I have create/modified unit tests to cover this change
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to documentation
  • I have run TAF: <link to TAF run>
  • I have run SiteImprove on pages impacted by changes

@github-actions github-actions bot added the bug Something isn't working label Nov 15, 2024
@HMS17 HMS17 marked this pull request as ready for review November 20, 2024 19:27
@HMS17 HMS17 requested review from a team, davedrp and mlm483 and removed request for a team November 20, 2024 19:30
@HMS17 HMS17 merged commit 3129f1a into develop Nov 27, 2024
2 checks passed
@HMS17 HMS17 deleted the bug/BI-2343 branch November 27, 2024 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants