Skip to content

Commit

Permalink
Update change log
Browse files Browse the repository at this point in the history
  • Loading branch information
Matt Young committed Nov 20, 2024
1 parent bd3b4dd commit d637754
Show file tree
Hide file tree
Showing 25 changed files with 295 additions and 41 deletions.
4 changes: 3 additions & 1 deletion CHANGES.markdown
Original file line number Diff line number Diff line change
Expand Up @@ -23,9 +23,11 @@ Bug fixes and minor enhancements.
* Crash on Windows when opening Print and Print Preview dialog [873](https://github.com/Brewtarget/brewtarget/issues/873)
* Crash when you click Yes or No in the pop-up about downloading the latest version [878](https://github.com/Brewtarget/brewtarget/issues/878)
* Drop down menu for Style and Equipment are so narrow, cannot see contents [879](https://github.com/Brewtarget/brewtarget/issues/879)
* OG doesn't immediately change when adding malt to a recipe [880](https://github.com/Brewtarget/brewtarget/issues/880)
* IBU doesn't update when adding hops [881](https://github.com/Brewtarget/brewtarget/issues/881)

### Release Timestamp
Sun, 17 Nov 2024 04:00:11 +0100
Tue, 19 Nov 2024 04:00:11 +0100

## v4.0.10
Bug fixes and minor enhancements.
Expand Down
7 changes: 7 additions & 0 deletions src/Logging.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@

#include <sstream> // For std::ostringstream

//#include <stacktrace>
#include <boost/stacktrace.hpp>

#include <QApplication>
Expand Down Expand Up @@ -527,11 +528,17 @@ QString Logging::getStackTrace() {
//
// TBD: Once all our compilers have full C++23 support, we should look at switching to <stacktrace> in the standard
// library.
// As at 2024-11-19, according to https://en.cppreference.com/w/cpp/compiler_support, Clang and Apple Clang do
// not have support for <stacktrace> (and GCC needs to be version 14 to have support enabled by default.
//
std::ostringstream stacktrace;
stacktrace << boost::stacktrace::stacktrace();
QString returnValue;
QTextStream returnValueAsStream(&returnValue);
// What we'd like to be able to write:
// returnValueAsStream << "\nStacktrace:\n" << QString::fromStdString( std::to_string(std::stacktrace::current()));
// What we use in the meantime:
returnValueAsStream << "\nStacktrace:\n" << QString::fromStdString(stacktrace.str());

return returnValue;
}
2 changes: 1 addition & 1 deletion translations/bt_ca.ts
Original file line number Diff line number Diff line change
Expand Up @@ -8484,7 +8484,7 @@ El volum final al primari és de %1.</translation>
<translation type="unfinished"></translation>
</message>
<message>
<source>(See Boil tab below)</source>
<source>See Boil tab below</source>
<translation type="unfinished"></translation>
</message>
</context>
Expand Down
2 changes: 1 addition & 1 deletion translations/bt_cs.ts
Original file line number Diff line number Diff line change
Expand Up @@ -8336,7 +8336,7 @@ Celkový objem pro hlavní kvašení je %1.</translation>
<translation type="unfinished"></translation>
</message>
<message>
<source>(See Boil tab below)</source>
<source>See Boil tab below</source>
<translation type="unfinished"></translation>
</message>
</context>
Expand Down
Loading

0 comments on commit d637754

Please sign in to comment.