Improve keyboard usage and reduce boilsize by deadspace. #776
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for this. I'll have a proper look soon (off to a wedding this weekend) but looks good from a first glance. |
Add explanatory comment
matty0ung
approved these changes
Oct 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using keyboard to move slider for mash designer values are not updated.
I've switched the event that we connect to, so this usecase would be supported.
Boil size should also be reduced by the lauter deadspace in calculation.
I've simply substracted it if it's defined in the equipment.
Please take special consideration when reviewing this PR as I'm not a developer by profession.
I'm not aware if this has any impact or implications on other parts of Brewtarget.
Cheers!