Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some BeerXML fixes #854

Merged
merged 2 commits into from
Oct 12, 2024
Merged

Some BeerXML fixes #854

merged 2 commits into from
Oct 12, 2024

Conversation

matty0ung
Copy link
Contributor

@matty0ung matty0ung commented Oct 12, 2024

This fixes:

  • Equipment should be optional in Recipes in BeerXML
  • Crash when you mouse-over a Recipe without Equipment
  • We should accept "incorrect" BeerXML that has more than one tag on the first line
  • We should accept "incorrect" BeerXML that omits one or more of the required VERSION tags

See #853.

Also turning off the automatic signing requests on the overnight Windows builds, since there is manual intervention required to approve signing.

@matty0ung matty0ung merged commit ee32db5 into Brewtarget:develop Oct 12, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant