Various fixes and tidy-up #864
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This includes a database upgrade that fixes (and simplifies) how we store recipe instructions. Prior database schema was set up to allow instructions to be shared between different recipes but this (a) is not possible in the UI and (b) doesn't make a massive amount of sense. So now Instructions belong to their Recipe. Plus they now share all the same "step" logic as mash steps, boil steps and fermentation steps. Simplifying and correcting the data model here is also a step along the way to adding in the ability to share mash/boil/fermentation profiles between recipes.
This PR should also fix:
And I'll probably do a few commits against this PR to also get a fix for: