-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update vrf classes #344
update vrf classes #344
Conversation
Wow! This looks really great --- thanks for the contribution I will try to look through this by next week and give comments. I think there may be some overlap with #257 which is completely fine, and it will be great to have the heat pump / VRF concepts integrated together |
It occurred to me that there are some packaged units called window/through_wall/self-contained air conditioners, which contain indoor units and outdoor units. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution. This would be very useful, though I realized that there are several concepts that the contributor misunderstood from Brick's original intention. I left several comments, but they are not exhaustive. I will leave general comments here and review this again after the contributor's update.
Tags are conceptual component of the class. You can check here: https://docs.brickschema.org/brick/concepts.html. I see the patterns where you use tags as a placeholder for possible relations of the class (e.g., subcomponents or points of a target equipment). However, Brick currently doesn't model that, though it's in our future road map in a different way. Check that and please update the PR.
Also, in Brick's general design principle, we focus on concepts with actual use cases. E.g., though I understand what Header
means but its use cases are not clear. Please review the proposed concepts with unclear use cases.
The current PR interchangeably use Systems and Equipment. Please check the documentation and distinguish them. I understand some types of equipment are often considered as a system, but the documentation would help you understand the difference in our modeling.
Finally, please put some examples with the proposed design. We normally don't mandate adding examples, but given that the current proposal is exhaustive, an example would be super helpful.
Thanks again for the huge contribution and I'd love to make this aligned with Brick soon.
TAG.Heat, | ||
TAG.Cool, | ||
TAG.System, | ||
TAG.Indoor_Unit, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These Units do not have to be part of the system's tags, especially given that the tags are "necessary" conditions for the class.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Units may be a part of the system, but it doesn't mean that it has to be the tags for the system class.
@@ -50,6 +50,71 @@ | |||
}, | |||
}, | |||
"Steam_System": {"tags": [TAG.Steam, TAG.System]}, | |||
"Refrigerant_System": { | |||
"tags": [TAG.Fluorocarbon_Refrigerant, TAG.Hydrocarbon_Refrigerant, TAG.System], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In this case, the tags should be just "Refrigerant" instead of the types of refrigerant. The tags are "necessary" conditions but in my understanding those refrigerant are may or may not be used together.
TAG.System, | ||
TAG.Indoor_Unit, | ||
TAG.Outdoor_Unit, | ||
TAG.Mode_Switch_Box |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Similar to units in the previous comment. Mode_Switch_Box may be isPartOf
a system but it shouldn't be a tag of the system.
TAG.Outdoor_Unit, | ||
TAG.Mode_Switch_Box], | ||
"subclasses":{ | ||
"VRF_Heat_Pump_System": { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I feel this is Equipment
instead of System
. Would you agree with it?
TAG.Mode_Switch_Box | ||
], | ||
}, | ||
"VRF_Heat_Recovery_System": { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same for this, would it be a piece of Equipment
instead of a System
?
For system vs equipment, check
https://brickschema.org/ontology/1.2/classes/System/
https://brickschema.org/ontology/1.2/classes/Equipment/
"Packaged_Terminal_Air_Conditioner": { | ||
"tags": [ | ||
TAG.Equipment, | ||
TAG.Packaged_Terminal_Air_Conditioner, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Packaged_Terminal_Air_Conditioner should be a class and its tags should represent unbreakable aspects of the class. I feel you are confused between classes and tags in general. I will give an explanation in the overall comment.
TAG.Valve, | ||
], | ||
}, | ||
"Packaged_Air_Conditioner": { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does Packaged_Air_Conditioner exist in different forms other than Packaged_Terminal_Air_Conditioner
?
(If it does, Packaged_Terminal_Air_Conditioner
should be a subclass of the other.
TAG.Return, | ||
TAG.Setpoint, | ||
TAG.Point, | ||
TAG.sensor, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
typo
TAG.Supply, | ||
TAG.Return, | ||
TAG.Setpoint, | ||
TAG.Point, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Equipment shouldn't have Point usually.
@@ -745,6 +871,11 @@ | |||
}, | |||
}, | |||
}, | |||
"Gas_Valve": {"tags": [TAG.Gas, TAG.Valve, TAG.Equipment]}, | |||
"Four_Way_Valve": {"tags": [TAG.Valve, TAG.Equipment]}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add Four and Way as tags.
Closing so we can continue development in a single location on a more recent version of Brick (see #589) |
Sorry, in the middle of too many things, dissertation, new home, marriage, pregnancy, abortion, and switching jobs, will update it when possible. |
No worries @jli113 ; we will use what you've given us in this issue. We are just moving development to a fresh PR so it is easier to incorporate into Brick |
Adding the following entities:
https://brickschema.org/schema/Brick#Hydrocarbon_Refrigerant,"Hydrocarbon Refrigerants are natural, nontoxic refrigerants that have no ozone depleting properties and absolutely minimal global warming potential. The most efficient and environmentally safe refrigerants in the world are the five natural refrigerants which are Air, Water, Carbon Dioxide, Ammonia and Hydrocarbons.",https://www.engas.com.au/about/about-hydrocarbon-refrigerants/
https://brickschema.org/schema/Brick#Fluorocarbon_Refrigerant,"Although they can be found in nature, the gases used are industrial gases, just like HFCs & HFOs, and are produced in refineries or other industrial facilities.",
https://brickschema.org/schema/Brick#CFC,"Chlorofluorocarbons (CFCs): when derived from methane and ethane these compounds have the formulae CClmF4−m and C2ClmF6−m, where m is nonzero. More than 98% of the CFCs used in MDIs have already been phased out, and will disappear completely in 2016, a significant milestone following 30 years of concerted global action to protect the ozone layer.",
https://brickschema.org/schema/Brick#HCFC,"Hydro-chlorofluorocarbons (HCFCs): when derived from methane and ethane these compounds have the formula CClmFnH4−m−n and C2ClxFyH6−x−y, where m, n, x, and y are nonzero. New production and import of most HCFCs were phased out as of 2020. The most common HCFC in use today is HCFC-22 or R-22, a refrigerant still used in existing air conditioners and refrigeration equipment. ",
https://brickschema.org/schema/Brick#HFC,"Hydrofluorocarbons (HFCs): when derived from methane, ethane, propane, and butane, these compounds have the respective formulae CFmH4−m, C2FmH6−m, C3FmH8−m, and C4FmH10−m, where m is nonzero. An HFC phase-down under the Montreal Protocol was agreed in Kigali, Rwanda, in October 2016. Developed countries will phase-down their production and imports of HFCs by 85% between 2019 and 2036. Developing countries will also phase-down their HFC production and imports.",
https://brickschema.org/schema/Brick#HFO,"Hydrofluoroolefins (HFOs) are unsaturated organic compounds composed of hydrogen, fluorine and carbon.",https://en.wikipedia.org/wiki/Hydrofluoroolefin
https://brickschema.org/schema/Brick#R410A,"R-410A, sold under the trademarked names AZ-20, EcoFluor R410, Forane 410A, Genetron R410A, Puron, and Suva 410A, is a zeotropic but near-azeotropic mixture of difluoromethane (CH2F2, called R-32) and pentafluoroethane (CHF2CF3, called R-125) that is used as a refrigerant in air conditioning applications",https://en.wikipedia.org/wiki/R-410A
https://brickschema.org/schema/Brick#R134a,"1,1,1,2-Tetrafluoroethane (also known as norflurane (INN), R-134a, Freon 134a, Forane 134a, Genetron 134a, Green Gas, Florasol 134a, Suva 134a, or HFC-134a) is a hydrofluorocarbon (HFC) and haloalkane refrigerant with thermodynamic properties similar to R-12 (dichlorodifluoromethane) but with insignificant ozone depletion potential and a lower 100-year global warming potential (1,430, compared to R-12's GWP of 10,900).[2] It has the formula CF3CH2F and a boiling point of −26.3 °C (−15.34 °F) at atmospheric pressure.","https://en.wikipedia.org/wiki/1,1,1,2-Tetrafluoroethane"
https://brickschema.org/schema/Brick#R1234yf,"2,3,3,3-Tetrafluoropropene, HFO-1234yf, is a hydrofluoroolefin (HFO) with the formula CH2=CFCF3. It is also designated R-1234yf as the first of a new class of refrigerants: it is marketed under the name Opteon YF by Chemours and as Solstice YF by Honeywell.","https://en.wikipedia.org/wiki/2,3,3,3-Tetrafluoropropene"
https://brickschema.org/schema/Brick#Liquid_Hydrocarbon_Refrigerant,,
https://brickschema.org/schema/Brick#Liquid_Hydrofluoric_Refrigerant,,
https://brickschema.org/schema/Brick#Liquid_CFC,,
https://brickschema.org/schema/Brick#Liquid_HCFC,,
https://brickschema.org/schema/Brick#Liquid_HFC,,
https://brickschema.org/schema/Brick#Liquid_HFO,,
https://brickschema.org/schema/Brick#Liquid_R410A,,
https://brickschema.org/schema/Brick#Liquid_R134a,,
https://brickschema.org/schema/Brick#Liquid_R1234yf,,
https://brickschema.org/schema/Brick#Refrigerant_System,"Refrigerant systems operate on the direct expansion (DX) principle meaning that heat is transferred to or from the space directly by circulating refrigerant to evaporators located near or within the conditioned space.",https://www.seedengr.com/Variable%20Refrigerant%20Flow%20Systems.pdf
https://brickschema.org/schema/Brick#Single_Split_System,"Split type air conditioning systems are one-to-one systems consisting of one evaporator (fan coil) unit connected to an external condensing unit. Both the indoor and outdoor units are connected through copper tubing and electrical cabling.",https://www.seedengr.com/Variable%20Refrigerant%20Flow%20Systems.pdf
https://brickschema.org/schema/Brick#Multi_Split_System,"A multi-type air conditioning system operates on the same principles as a split type air-conditioning system with multiple indoor units connected to one external outdoor unit.",https://www.seedengr.com/Variable%20Refrigerant%20Flow%20Systems.pdf
https://brickschema.org/schema/Brick#VRF_System,"VRF systems connect the outdoor section to several the indoor sections. VRF systems continually adjust the flow of refrigerant to each indoor evaporator. The control is achieved by continually varying the flow of refrigerant through a pulse modulating valve (PMV) whose opening is determined by the microprocessor receiving information from the thermistor sensors in each indoor unit. The indoor units are linked by a control wire to the outdoor unit which responds to the demand from the indoor units by varying its compressor speed to match the total cooling and/or heating requirements.",https://www.seedengr.com/Variable%20Refrigerant%20Flow%20Systems.pdf
https://brickschema.org/schema/Brick#VRF_Heat_Pump_System,"VRF heat pump systems permit heating or cooling in all of the indoor units but NOT simultaneous heating and cooling. When the indoor units are in the cooling mode, they act as evaporators; when they are in the heating mode, they act as condensers. These are also known as two-pipe systems.",https://www.seedengr.com/Variable%20Refrigerant%20Flow%20Systems.pdf
https://brickschema.org/schema/Brick#VRF_Heat_Recovery_System,"Variable refrigerant flow systems with heat recovery (VRF-HR) capability can operate simultaneously in heating and/or cooling mode, enabling heat to be used rather than rejected as it would be in traditional heat pump systems.",https://www.seedengr.com/Variable%20Refrigerant%20Flow%20Systems.pdf
https://brickschema.org/schema/Brick#Indoor_Unit,Indoor boxes with heat exchangers,
https://brickschema.org/schema/Brick#Outdoor_Unit,Outdoor boxes with heat exchangers and compressors,
https://brickschema.org/schema/Brick#Mode_Switch_Box,"MS boxes with a built-in solenoid valves switch the modes of operation of indoor units, allowing different groups of units connected to the MS box to work simultaneously in different modes: cooling or heating, with precisely selected performance.",https://midea.mt/index.php/product/mode-switch-box/
https://brickschema.org/schema/Brick#hasConnection,"The subject is linked with the object in the context of some sequential process; some media is between them.",
https://brickschema.org/schema/Brick#Four_Way_Valve,"The four-way valve or four-way cock is a fluid control valve whose body has four ports equally spaced round the valve chamber and the plug has two passages to connect adjacent ports.",https://en.wikipedia.org/wiki/Four-way_valve
https://brickschema.org/schema/Brick#Check_Valve,"A check valve, non-return valve, reflux valve, retention valve, foot valve, or one-way valve is a valve that normally allows fluid (liquid or gas) to flow through it in only one direction.",https://en.wikipedia.org/wiki/Check_valve
https://brickschema.org/schema/Brick#Electronic_Expansion_Valve,"The electronic expansion valve (EEV) operates with a much more sophisticated design. EEVs control the flow of refrigerant entering a direct expansion evaporator. They do this in response to signals sent to them by an electronic controller.",https://www.achrnews.com/articles/95056-electronic-expansion-valves-the-basics
https://brickschema.org/schema/Brick#Solenoid_Valve,"A solenoid valve is an electromechanically operated valve. Solenoid valves differ in the characteristics of the electric current they use, the strength of the magnetic field they generate, the mechanism they use to regulate the fluid, and the type and characteristics of fluid they control. The mechanism varies from linear action, plunger-type actuators to pivoted-armature actuators and rocker actuators. The valve can use a two-port design to regulate a flow or use a three or more port design to switch flows between ports. Multiple solenoid valves can be placed together on a manifold.",https://en.wikipedia.org/wiki/Solenoid_valve
https://brickschema.org/schema/Brick#Header,"The refrigerant pipe-work uses a number of separation tubes and/or headers, a header has more than 2 branches.",https://www.seedengr.com/Variable%20Refrigerant%20Flow%20Systems.pdf
https://brickschema.org/schema/Brick#Separation_Tube,"The refrigerant pipe-work uses a number of separation tubes and/or headers, a separation tube has 2 branches.",https://www.seedengr.com/Variable%20Refrigerant%20Flow%20Systems.pdf
https://brickschema.org/schema/Brick#Capillary_Tube,"Capillary tube is one of the most commonly used throttling devices in the refrigeration and the air conditioning systems. The capillary tube is a copper tube of very small internal diameter. It is of very long length and it is coiled to several turns so that it would occupy less space. The internal diameter of the capillary tube used for the refrigeration and air conditioning applications varies from 0.5 to 2.28 mm (0.020 to 0.09 inches). Capillary tube used as the throttling device in the domestic refrigerators, deep freezers, water coolers and air conditioners.",https://www.brighthubengineering.com/hvac/58420-capillary-tube-for-refrigeration-and-air-conditioning-systems/
https://brickschema.org/schema/Brick#Drier,"A drier as its name imply is used to remove the moisture from the refrigerant.",https://www.airconditioning-systems.com/filterdriers.html
https://brickschema.org/schema/Brick#Accumulator,"A suction accumulator is used to prevent liquid refrigerant floodback to the compressor. The accumulator protects the system components. It is located on the low-pressure side of the circuit between the evaporator outlet and the compressor suction port.",https://hvacrschool.com/whast-is-a-suction-accumulator/