include HCal Endcap in run_thetamodulemerged.py

[mmlynari]

• will work when the following PRs are merged
  update CellPositionsTool for HCal Allegro HEP-FCC/k4RecCalorimeter#91
  addExtensionsToHCalAllegro key4hep/k4geo#350

[giovannimarchiori]

Hi @mmlynari ,
good to see the HCAL endcap digitisation coming to light!
Please bear in mind that we're phasing out the use of fccrun for the whole sim+reco, our default now is to use ddsim for sim and k4 run for digi+reco, so the changes here will have to be ported to https://github.com/HEP-FCC/FCC-config/blob/main/FCCee/FullSim/ALLEGRO/ALLEGRO_o1_v03/run_digi_reco.py, so you might have started directly from there. Anyway, if it's easier for you to test the geometry / segmentation / digitisation chain with the old setup, we can start like this and then we can help you migrate this script to FCC-config

[giovannimarchiori]

hi @mmlynari you mentioned in the ALLEGRO meeting that you had implemented also the merging of the hcal endcap cells and tested with clustering, but I can't see these changes here - where are they? I am asking because I am working on an updated version of the digi+reco script for the calorimeters (with ddsim+kr4un) and I would like to include also the HCAL endcap

[mmlynari]

Hi @giovannimarchiori , sorry, I forgot to update the scripts with the most up-to-date changes. I committed it now

[giovannimarchiori]

Thanks! I don't see where the name of 2nd endcap readout is defined but I assume it's the 2nd one in k4geo HCalEndcapReadout_phitheta ?

[mmlynari]

my bad. yes, it's HCalEndcapReadout_phitheta and I updated the code

[giovannimarchiori]

Thanks! And about the SW clustering, should I pass the HCAL endcap collection to the tower tool via hcalExtBarrelCells or hcalEndcapCells? I'm currently going with the latter

[mmlynari]

hcalExtBarrelCells

I think hcalEndcapCells is more appropriate. just please double-check that it works. because I was only testing it for standalone hcal, and I am not 100% sure that it won't crash when we include also other subdetectors

[giovannimarchiori]

Hi @mmlynari ,
for the hcal barrel, can we also switch to the new positioning tool with the layer data, i.e. move from

cellPositionHcalBarrelTool = CellPositionsHCalBarrelPhiThetaSegTool(

to

cellPositionHcalBarrelTool = CellPositionsHCalPhiThetaSegTool(

?

do we need to pass some extra parameters (detectorName and so on)?

[giovannimarchiori]

thanks a lot @mmlynari!
You can see how the new digi+reco script to be used in the k4RecCalorimeter tests looks like: https://github.com/HEP-FCC/k4RecCalorimeter/blob/f9a11004c578938983496180caa4ec9cebe10e94/RecFCCeeCalorimeter/tests/options/ALLEGRO_o1_v03_digi_reco.py

I think I put the barrel and endcap HCal stuff in there correctly but it'd be good if you could have a look.

I ran over 100 events of 50-GeV pions at theta=90 and 100 events of 50-GeV pions at theta=160 and I get clusters of energies typically around 40-45 GeV in all the events so this looks pretty good to me