Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MM-813: Fixed the issue of wrong name shown in subscription when PR is moved from draft to ready for review #38

Closed
wants to merge 1 commit into from
Closed

MM-813: Fixed the issue of wrong name shown in subscription when PR is moved from draft to ready for review #38

wants to merge 1 commit into from

Conversation

Kshitij-Katiyar
Copy link

Description

Fixed the issue of the wrong name shown in the subscription when PR is moved from draft to ready for review

Screenshots

Existing

Screenshot from 2024-08-26 17-33-26

Updated

Screenshot from 2024-08-26 17-33-51

What to test

  • Create a subscription for a repo
  • Create a PR with user B and mark it as draft
  • Mark the PR as ready for review from user A

Expected

  • #new-pull-request by B

Actual

  • #new-pull-request by A

@raghavaggarwal2308 raghavaggarwal2308 changed the base branch from master to MI-2481 August 27, 2024 07:45
@raghavaggarwal2308 raghavaggarwal2308 changed the base branch from MI-2481 to master August 27, 2024 07:45
@Kshitij-Katiyar
Copy link
Author

Created a PR on mattermost remote with all the changes of this PR, hence closing this one

@raghavaggarwal2308 raghavaggarwal2308 deleted the MM-813 branch August 27, 2024 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raghavaggarwal2308 raghavaggarwal2308 raghavaggarwal2308 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Kshitij-Katiyar @raghavaggarwal2308