Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MM-794: returning proper JSON response from APIs #39

Closed
wants to merge 6 commits into from

Conversation

Kshitij-Katiyar
Copy link

@Kshitij-Katiyar Kshitij-Katiyar commented Aug 30, 2024

Summary

returning proper JSON response from APIs

Screenshots

Screenshot from 2024-09-03 17-13-26
Screenshot from 2024-09-03 17-14-56

@Kshitij-Katiyar Kshitij-Katiyar changed the base branch from master to MI-2481 August 30, 2024 11:06
@Kshitij-Katiyar Kshitij-Katiyar changed the base branch from MI-2481 to master August 30, 2024 11:06
Copy link

@raghavaggarwal2308 raghavaggarwal2308 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please test the PR for error responses of all the APIs also add logging wherever necessary

server/plugin/api.go Show resolved Hide resolved
@Kshitij-Katiyar
Copy link
Author

Created a PR on mattermost remote with all these changes hence closing this one

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants