[MM-564]: Fixed the subscribe permissions config preventing system admins from creating subscriptions in DM or GM #82
Conversation
…mins from creating subscriptions in DM or GM
server/subscribe.go
Outdated
| @@ -702,7 +702,9 @@ func (p *Plugin) hasPermissionToManageSubscription(instanceID types.ID, userID, | |||
| return errors.New("is not channel admin") | |||
| } | |||
| default: | |||
| return errors.New("can only subscribe in public and private channels") | |||
There was a problem hiding this comment.
Looking at this makes me feel that subs were not allowed in DM/GM and our changes overrides that
There was a problem hiding this comment.
Yes, as requested in the issue, the current PR changes allow the system admin to create subscriptions in DM/GM. Let me know if we need to get the approval from Doug before doing these changes, I will revert the changes
There was a problem hiding this comment.
@Kshitij-Katiyar Yes we should get a confirmation here, that the current implmentation does not allow subs in DM/GM, do we need to update that.
Also, it was mentioned in the issue that the error they are receiving is regarding permisssions and not "not allowed in DM/gM.....". Did we look into that?
There was a problem hiding this comment.
This is the error mentioned in the issue, the error message is apt to the condition. Reverting the changes involving change with plugin functionality. Will add a confirmation from Doug once we create a PR on mm
Kshitij-Katiyar
force-pushed
the
MM-564
branch
from
26626e3 to
e21ce63
Compare
Summary
Fixed the subscribe permissions config preventing system admins from creating subscriptions in DM or GM
How to test
Mattermost Roles Allowed to Edit Jira Subscriptionsconfig of the Jira plugin toUsers who can manage channel settingsorUsers who can manage teams/Jira subscribecommand in a DM or GMCurrent Behaviour
Updated Behaviour