forked from mattermost/mattermost-plugin-jira
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MM-1025]: Fixed the infinite loading state of tooltip modal #88
Closed
+96
−2
Closed
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
2f22e6b
[MM-1025]: Fixed the infinite loading state of tooltip modal
Kshitij-Katiyar 20302a7
[MM-1025]: Updated the icon and added svg wrapper
Kshitij-Katiyar 3ea6e3f
[MM-1025]: review fixes
Kshitij-Katiyar 9c12442
[MM-1025]: review fixes
Kshitij-Katiyar 8049a4b
[MM-1081]: fixed lint
Kshitij-Katiyar File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,12 @@ | ||
import React from 'react'; | ||
|
||
type SvgIconNames = 'exclamationTriangle'; | ||
|
||
export const SVGIcons: Record<SvgIconNames, JSX.Element> = { | ||
exclamationTriangle: ( | ||
<> | ||
raghavaggarwal2308 marked this conversation as resolved.
Show resolved
Hide resolved
|
||
<path d='M7.938 2.016A.13.13 0 0 1 8.002 2a.13.13 0 0 1 .063.016.15.15 0 0 1 .054.057l6.857 11.667c.036.06.035.124.002.183a.2.2 0 0 1-.054.06.1.1 0 0 1-.066.017H1.146a.1.1 0 0 1-.066-.017.2.2 0 0 1-.054-.06.18.18 0 0 1 .002-.183L7.884 2.073a.15.15 0 0 1 .054-.057m1.044-.45a1.13 1.13 0 0 0-1.96 0L.165 13.233c-.457.778.091 1.767.98 1.767h13.713c.889 0 1.438-.99.98-1.767z'/> | ||
<path d='M7.002 12a1 1 0 1 1 2 0 1 1 0 0 1-2 0M7.1 5.995a.905.905 0 1 1 1.8 0l-.35 3.507a.552.552 0 0 1-1.1 0z'/> | ||
</> | ||
), | ||
}; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,36 @@ | ||
import React from 'react'; | ||
|
||
type SVGWrapperProps = { | ||
viewBox?: string; | ||
height?: number; | ||
width?: number; | ||
fill?: string; | ||
onHoverFill?: string; | ||
children: React.ReactNode; | ||
className?: string; | ||
} | ||
|
||
const SVGWrapper = ({ | ||
children, | ||
viewBox = '0 0 16 16', | ||
height = 36, | ||
width = 36, | ||
fill = 'none', | ||
onHoverFill, | ||
className = '', | ||
}: SVGWrapperProps): JSX.Element => { | ||
return ( | ||
<svg | ||
width={width} | ||
height={height} | ||
viewBox={viewBox} | ||
fill={onHoverFill || fill} | ||
xmlns='http://www.w3.org/2000/svg' | ||
className={className} | ||
> | ||
{children} | ||
</svg> | ||
); | ||
}; | ||
|
||
export default SVGWrapper; |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add some padding
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also get this CSS reviewed from @avas27JTG
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @avas27JTG, can you please review these css