Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MI-3826]: Reducers and Containers test cases #38

Merged
merged 7 commits into from
Dec 13, 2023
Merged

[MI-3826]: Reducers and Containers test cases #38

merged 7 commits into from
Dec 13, 2023

Conversation

SaurabhSharma-884
Copy link

Screenshot from 2023-12-09 16-43-06

@SaurabhSharma-884 SaurabhSharma-884 self-assigned this Dec 9, 2023
ayusht2810
ayusht2810 reviewed Dec 11, 2023
View reviewed changes
Copy link

@ayusht2810 ayusht2810 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix ci

webapp/src/tests/mockState.ts Outdated Show resolved Hide resolved
webapp/src/tests/mockState.ts Outdated Show resolved Hide resolved
webapp/src/reducers/spinner/index.test.ts Outdated Show resolved Hide resolved
webapp/src/reducers/spinner/index.test.ts Outdated Show resolved Hide resolved
webapp/src/reducers/dialog/index.test.ts Outdated Show resolved Hide resolved
webapp/src/reducers/connectedState/index.test.ts Outdated Show resolved Hide resolved
@avas27JTG avas27JTG self-requested a review December 13, 2023 11:02
@avas27JTG
Copy link

@SaurabhSharma-884 @ayusht2810 follow any one standard either keep Should(capitalized) or should(all small case). I would prefer capitalized.

Base automatically changed from MI-3827 to epic-ui December 13, 2023 13:51
@SaurabhSharma-884 SaurabhSharma-884 merged commit 9b437fa into epic-ui Dec 13, 2023
1 check passed
@SaurabhSharma-884 SaurabhSharma-884 deleted the MI-3826 branch December 13, 2023 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ayusht2810 ayusht2810 ayusht2810 approved these changes

@avas27JTG avas27JTG Awaiting requested review from avas27JTG

Assignees

@SaurabhSharma-884 SaurabhSharma-884

Labels
Phase-1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@SaurabhSharma-884 @avas27JTG @ayusht2810