Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MI-3832] Add websocket events for linking and unlinking channels #42

Merged
merged 10 commits into from
Dec 15, 2023
Merged

[MI-3832] Add websocket events for linking and unlinking channels #42

merged 10 commits into from
Dec 15, 2023

Conversation

ayusht2810
Copy link

Summary

  • Added websocket events for linking and unlinking channels
  • Added logic to publish websocket events when no parameters are passed while linking the channels
  • Fixed unit test cases

@ayusht2810 ayusht2810 self-assigned this Dec 11, 2023
@ayusht2810 ayusht2810 changed the title [MI-3832] Add websocket evetns for linking and unlinking channels [MI-3832] Add websocket events for linking and unlinking channels Dec 11, 2023
raghavaggarwal2308
raghavaggarwal2308 reviewed Dec 11, 2023
View reviewed changes
Copy link

@raghavaggarwal2308 raghavaggarwal2308 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fic CI

server/command_test.go Outdated Show resolved Hide resolved
Base automatically changed from MI-3828 to epic-ui December 15, 2023 13:19
SaurabhSharma-884 and others added 2 commits December 15, 2023 19:26
@SaurabhSharma-884 @ayusht2810
[MI-3831]: Link channels modal (#40)
7d082b6 
* [MI-3831]: Link channels modal

* [MI-3831]: Fix lint errors

* [MI-3831]: Update naming

* [MI-3833]: Link channel modal integration (#43)

* [MI-3833]: Link Channel Modal integration

* [MI-3833]: Add constants

* [MI-3833]: Update constants

* [MI-3837]: Integrate webhooks and enhancements (#47)

* [MI-3837]: Integrate webhooks and enhancements

* [MI-3837]: Remove yarn lock

* [MI-3834] Add unlink button on hover state on linked channel list (#45)

* [MI-3834] Add unlink button on hover state on linked channel list

* [MI-3834] Update style and props of unlink button

* [MI-3836] Integrate API to unlink channels and websocket event (#46)

* [MI-3836] Integrate API to unlink channels and websocket event

* [MI-3836] Fix issue of alert not visible

* [MI-3836] Update dialog component

* [MI-3836] Minor review fixes and revert some changes

---------

Co-authored-by: Ayush Thakur <[email protected]>

* [MI-3831]: Minor refactoring

* [MI-3831]: Update UI-Lib version

---------

Co-authored-by: Ayush Thakur <[email protected]>
@SaurabhSharma-884
Merge branch 'epic-ui' of s.github.com:Brightscout/mattermost-plugin-…
30447cc 
…msteams-sync into MI-3832
@ayusht2810 ayusht2810 merged commit 58c9141 into epic-ui Dec 15, 2023
1 check passed
@ayusht2810 ayusht2810 deleted the MI-3832 branch December 15, 2023 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kshitij-Katiyar Kshitij-Katiyar Kshitij-Katiyar approved these changes

@raghavaggarwal2308 raghavaggarwal2308 raghavaggarwal2308 approved these changes

Assignees

@ayusht2810 ayusht2810

Labels
Phase-3
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ayusht2810 @raghavaggarwal2308 @Kshitij-Katiyar @SaurabhSharma-884