Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MI-3835] Add logic to hide/show RHS on the basis of system console setting #44

Merged
merged 9 commits into from
Dec 14, 2023
Merged

[MI-3835] Add logic to hide/show RHS on the basis of system console setting #44

merged 9 commits into from
Dec 14, 2023

Conversation

ayusht2810
Copy link

@ayusht2810 ayusht2810 commented Dec 12, 2023 •
edited
Loading

Summary

  • Added logic to hide/show RHS on the basis of system console settings
  • Updated channel header icon
  • Wrapped utils scss classes in unique plugin class and updated all the corresponding components and containers
  • Fixed unit test cases

@ayusht2810 ayusht2810 self-assigned this Dec 12, 2023
SaurabhSharma-884
SaurabhSharma-884 requested changes Dec 12, 2023
View reviewed changes
webapp/src/index.tsx Show resolved Hide resolved
webapp/src/App.tsx Show resolved Hide resolved
webapp/src/App.tsx Outdated Show resolved Hide resolved
@ayusht2810 ayusht2810 requested a review from avas27JTG December 13, 2023 06:46
avas27JTG
avas27JTG approved these changes Dec 13, 2023
View reviewed changes
webapp/src/App.tsx Show resolved Hide resolved
webapp/src/App.tsx Show resolved Hide resolved
@ayusht2810 ayusht2810 changed the base branch from phase-1 to epic-ui December 13, 2023 11:00
@ayusht2810 ayusht2810 changed the title [MI-3835] Add logic to hide/show RHS on the presence of user in whitelist [MI-3835] Add logic to hide/show RHS on the basis of system console setting Dec 13, 2023
avas27JTG
avas27JTG reviewed Dec 14, 2023
View reviewed changes
plugin.json Outdated Show resolved Hide resolved
plugin.json
"display_name": "Enable RHS",
"type": "bool",
"help_text": "When true, user will be able to view RHS (right hand sidebar).",
"default": false
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this confirmed from Mike that initially don't show to anyone?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes

server/api.go Outdated Show resolved Hide resolved
webapp/src/constants/apiService.constant.ts Outdated Show resolved Hide resolved
webapp/src/constants/apiService.constant.ts Outdated Show resolved Hide resolved
@ayusht2810 ayusht2810 merged commit 20e6f16 into epic-ui Dec 14, 2023
1 check passed
@ayusht2810 ayusht2810 deleted the MI-3835 branch December 14, 2023 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@avas27JTG avas27JTG avas27JTG approved these changes

@SaurabhSharma-884 SaurabhSharma-884 SaurabhSharma-884 approved these changes

Assignees

@ayusht2810 ayusht2810

Labels
Phase-1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ayusht2810 @avas27JTG @SaurabhSharma-884