[GH-108]: Developed the UI for Admin setting console #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* setup webapp to the plugin * Added else statement to cmd switch case in manifest/main.go * [MI-3173]:Fixed the webapp registering * [MI-3173]:Pushed node_modules * [MI-3173]: Removed node_modules * [MI-3173]: Removed node_modules * Removed yarn from webapp * Removed RHS from the plugin and other minor changes * [MI-3173]: Fixed pluginId variable name in manifest_test.tsx * [MI-3173]: Removed error handling files from webapp/util for now * [MI-3173]: resolved unused imports in utils * [MI-3173]: Removed extra blank line from utils/index.ts * [MI-3173]: Removed some extra unnecessary files * Removed unnecessary files * [MI-3173]: Removed extra dependencies * [MI-3199]: Developed a table to display the existing config of plugin (#5) * Developed table to display existing configs of plugin * Updated .gitignore to exclude node_modules * Fixed .gitignore to exclude node_modules * Developed a table to display existing config * Developed a table to show existing plugin config * setup redux store and add reducer to show/hide attachment message modal * Added modal to show attachment message of config * Removed node modules * [MI-3199]: Removed node modules * [MI-3199]: Removed extra todo comments * [MI-3199]: Resolved missing imports in existingConfigTable * [MI-3199]: removed extra folders * [MI-3199]: Added eod to styles.css * [MI-3199]: Fixed review comments by abhishek * [MI-3230]: Developed a modal which opens on click of view button in config table (#6) * [MI-3230]: Developed a modal which opens on click of view button in config table * Added form in modal to accept the action details * [MI-3230]: Added view Action modal * [MI-3230]: FIxed indentation in existingConfigTable * [MI-3230: Fixed indentation in existingConfigTable * [MI-3230]: fixed indentation in existingConfigTable * [MI-3230]: Fixed indentation in existingConfigTable * [MI-3230]: Removed unwanted files from webapp * [MI-3230]: Fixed indentation * [MI-3230]: Removed extra padding from existingConfigTable * [MI-3230]: Improved the name of variables * [MI-3230]: Added eod, use type instead of interface * [MI-3230]: Used fat arrow function instead of normal function * [MI-3230]: Improved name of variable in editActionModal * [MI-3230]: Fixed some review changes by Abhishek * [MI-3230]: Added div to </> in existingConfigTable * [MI-3230]: Added curly braces to css file * [MI-3241] : Added delete config modal to the webapp (#7) * [MI-3241]: Added delete config modal * [MI-3241]: fixed indent in table * [MI-3241]: Fixed indent in existingConfigtable * [MI-3241]: Removed extra files from webapp * [MI-3241]: Resolved import not found * [MI-3241]: removed extra empty lines * [MI-3241]: Added corejs as dependency * [MI-3241]: removed duplicate react-dom dependency * [MI-3242]: Improved variable name in modal * [MI-3241]: add eod to modal files * [MI-3241]: removed extra div wrappers * [MI-3241]: Used fat arrow function instead of normal function * [MI-3241]: Fixed a syntax error in existingConfigTable * [MI-3241]: Fixed CI in existingConfigTable * [MI-3241]: Added curly brace to css file * [MI-3255]: Added svg icon and Tooltip (#8) * [MI-3255]: Added svg icon as button and added tooltip * [MI-3254]: Added add/edit config modal and add config button * [MI-3254]: Added add config button in existing config table * [MI-3254]: Added config and action edit modal * [MI-3254]: Fixed css of config modal and existing config table * [MI-3254]: Added services and utils file for plugin * [MI-3254]: added service and util files * [MI-3255]: Fixed some indentation * [MI-3255]: Removed some extra lines * [MI-3254]: Removed extra files from webapp * [MI-3255]: removed extra files from webapp * [MI-3255]: Fixed indentation * [MI-3255]: Fixed indentation * [MI-3255]: Removed extra lines and updated variable names * [MI-3255]: added null to config variable * [MI-3255]: Improved variable name in DeleteModal * [MI-3255]: Improved base URL fetching * [MI-3255]: Improved variable name to increase understandability * [MI-3274]: Integrated config table, view action modal & delete config modal (#10) * [MI-3275]: Fixed indentation and other lint errors * [MI-3274]: Integrated config table, view action & delete config modal * [MI-3274]: Used camelcase in type * [MI-3274]: Resolved the import order issue * [MI-3274]: Resolved import order * [MI-3274]: Used types instead of interface * [MI-3274]: Fixed indentation for CI * [MI-3274]: Fixed lint CI * [MI-3274]: Fixed conflict resolution error * [MI-3274]: Fixed error in plugin.json * [MI-3275]: Integrated config modal (#11) * [MI-3275]: Integrated config modal * [MI-3275]: destructured props in modal * [MI-3275]: Fixed message in delete modal * [MI-3275]: Fixed import order in modal * [MI-3275]: Resolved missing closing tag errors * [MI-3275]: Fixed indent for CI * [MI-3275]: Fixed indentation errors in CI * [MI-3275]: Removed evtra variables * [MI-3317]: Added validations to forms and enhancements (#12) * [MI-3317]: Added validations to forms * [MI-3317]: added EOD to style.css * [MI-3316]: Fixed some css * [MI-3317]: Fixed grammar of validation messages * [MI-3317]: Fixed grammar of validation message in action modal * [MI-3317]: added classname to each modal * [MI-3316]: added css to make modals stationary * [MI-3316]: Removed some extra files * [MI-3317]: removed some extra files * [MI-3317]: reduced the icon size of svg icons * [MI-3317]: Fixed grammar in actionModal message * [MI-3317]: removed an extra comment * [MI-3317]: Improved grammar of statements in config modal * [MI-3317]: Fixed grammar of message * [MI-3317]: Fixed import order * [MI-3317]: Fixed redundant if conditions and removed extra empty lines * [MI-3317]: Used fat-arrow function instead of normal function * [MI-3317]: Removed camelcase from css * [MI-3317]: Resolved conflicts and fixed CI * [MI-3317]: Fixed indentation errors * [MI-3317]: Improved the name of variables * [MI-3317]: Removed else and used return with if * [MI-3317]: Fixed the variable name in table * [MI-3317]: Fixed CSS according to abhishek's review * [MI-3355]: Added dropdown to choose teams and channels (#14) * [MI-3355]: Removed extra types * [MI-3355]: Improved message of view action modal * [MI-3355]: removed extra packages * [MI-3355]: Added eod to files * [MI-3355]: Fixed adding action functionality * [MI-3355]: Fixed the jump in UI during validation warnings * [MI-3355]: fixed maximum nested callback in useEffect * [MI-3355]: Fixed validation warnings in Add action modal * [MI-3355]: Added ellipses to the tables * [MI-3355]: updated API to fetch data in batches * [MI-3355]: Removed comment and fixed empty lines * [MI-3355]: Fixed css of modal visibility * [MI-3355]: Added svg icons to different file * [MI-3355]: Improvised the folder structure * [MI-3355]: Improved the variable name in existingConfigTable * [MI-3355]: Fixed error in adding new action to config with index zero * [MI-3355]: Fixed import issue of .d.ts files * [MI-3355]: Used fat-arrow function instead of normal functions * [MI-3355]: Installed types and packages for js-cookie * [MI-3355]: Setup reduxstore * [MI-3355]: Disabled dropdown during loading state * [MI-3355]: Improved getBaseUrl method * [MI-3355]: Improved the API call * [MI-3355]: Added constants and used baseUrl from redux state * [MI-3355]: Fixed jump in UI in edit action modal * [MI-3355]: Joined array of string with comma for messages & disabled dropdown incase of API failure * [MI-3355]: Added type of onChange function * [MI-3355]: Removed extra variables * [MI-3355]: Improved the validation conditions * [MI-3355]: Fixed css according to reviews by abhishek * [MI-3355]: Improved visibility of action successfull message * [MI-3355]: Used scss instead of css * [MI-3355]: Fixed the CSS of channel-added-to content * [MI-3355]: Added semicolons to types in common.d.ts * Update webapp/src/components/modals/actionModal.tsx Co-authored-by: Abhishek Verma <[email protected]> * Update webapp/src/components/tables/existingConfigTable.tsx Co-authored-by: Abhishek Verma <[email protected]> * Update webapp/src/components/svgIcons/svg.tsx Co-authored-by: Abhishek Verma <[email protected]> * [MI-3355]: Used px instead of % in css * [MI-3355]: Fixed some minor css * [MI-3355]: Removed extra spaces from existingConfigTable --------- Co-authored-by: Abhishek Verma <[email protected]> --------- Co-authored-by: Abhishek Verma <[email protected]> --------- Co-authored-by: Abhishek Verma <[email protected]> --------- Co-authored-by: Abhishek Verma <[email protected]> --------- Co-authored-by: Abhishek Verma <[email protected]> --------- Co-authored-by: Abhishek Verma <[email protected]> --------- Co-authored-by: Abhishek Verma <[email protected]> --------- Co-authored-by: Abhishek Verma <[email protected]> --------- Co-authored-by: Abhishek Verma <[email protected]>
Kshitij-Katiyar
changed the title
raghavaggarwal2308
requested changes
Sep 5, 2023
Makefile
Outdated
| webapp/.npminstall: | ||
| ifneq ($(HAS_WEBAPP),) | ||
| cd webapp && $(NPM) install | ||
| cd webapp && $(NPM) install --legacy-peer-deps |
raghavaggarwal2308
requested changes
Sep 7, 2023
Kshitij-Katiyar
changed the title
avas27JTG
reviewed
Sep 13, 2023
Comment on lines
+8
to
+11
| chrome: 66, | ||
| firefox: 60, | ||
| edge: 42, | ||
| safari: 12, |
There was a problem hiding this comment.
have we tested the UI flow on these browsers?
There was a problem hiding this comment.
tested on chrome and Firefox. Should we test it on edge and Safari also?
There was a problem hiding this comment.
Yes because its explicitly mentioned to support these browsers so it would be good to do a test.
You can use LamdaTest with BS email ID to test on Safari and Edge.
There was a problem hiding this comment.
As discussed with you, BS email doesn't have a subscription to LambaTest now. I conveyed the message to Kshitij, and he will inform this to Mick
raghavaggarwal2308
approved these changes
Sep 19, 2023
Co-authored-by: Abhishek Verma <[email protected]>
avas27JTG
approved these changes
Sep 28, 2023
Kshitij-Katiyar
changed the title
|
Tested this PR and faced an error while testing on local, please re-check:- Kindly re-check the error as it is a blocker for testing. |
…comebot into MM-108
- Fixed issue: UI breaking because of invalid assignment to config. - Removed the unnecessary check for delay field.
raghavaggarwal2308
requested changes
Feb 1, 2024
…ew constant and fix formatting
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Issue Link
mattermost-community#108
Screenshot