Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MI-3199]: Developed a table to display the existing config of plugin #5

Merged
merged 22 commits into from
Sep 1, 2023
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
22 commits
Select commit Hold shift + click to select a range
2a973c5
Developed table to display existing configs of plugin
Kshitij-Katiyar Jun 26, 2023
a3b66d0
Updated .gitignore to exclude node_modules
Kshitij-Katiyar Jun 26, 2023
664f8c2
Fixed .gitignore to exclude node_modules
Kshitij-Katiyar Jun 26, 2023
8c3cf4e
Developed a table to display existing config
Kshitij-Katiyar Jun 26, 2023
24e0ec1
Developed a table to show existing plugin config
Kshitij-Katiyar Jun 26, 2023
e5dea39
setup redux store and add reducer to show/hide attachment message modal
Kshitij-Katiyar Jun 27, 2023
cb86cf5
Added modal to show attachment message of config
Kshitij-Katiyar Jun 28, 2023
e3c57b2
Removed node modules
Kshitij-Katiyar Jun 28, 2023
2cd44bf
[MI-3199]: Removed node modules
Kshitij-Katiyar Jun 28, 2023
f0a2e04
Merge branch 'MI-3173' of github.com:Brightscout/mattermost-plugin-we…
Kshitij-Katiyar Jul 3, 2023
584af51
Merge branch 'MI-3173' of github.com:Brightscout/mattermost-plugin-we…
Kshitij-Katiyar Jul 3, 2023
c06c92a
[MI-3199]: Removed extra files and added eod in gitignore
Kshitij-Katiyar Jul 10, 2023
9e59fd3
[MI-3199]: Fixed lint errors
Kshitij-Katiyar Jul 10, 2023
4fd5dd2
Merge branch 'MI-3173' of github.com:Brightscout/mattermost-plugin-we…
Kshitij-Katiyar Jul 11, 2023
b20814b
[MI-3199]: Removed unwanted files from webapp
Kshitij-Katiyar Jul 19, 2023
414e864
[MI-3199]: Removed extra todo comments
Kshitij-Katiyar Aug 1, 2023
5e6f8b5
Merge branch 'MI-3173' of github.com:Brightscout/mattermost-plugin-we…
Kshitij-Katiyar Aug 1, 2023
5f667b0
[MI-3199]: Resolved missing imports in existingConfigTable
Kshitij-Katiyar Aug 1, 2023
4639074
[MI-3199]: removed extra folders
Kshitij-Katiyar Aug 2, 2023
4494be8
[MI-3199]: Added eod to styles.css
Kshitij-Katiyar Aug 21, 2023
2fbf310
[MI-3199]: Fixed review comments by abhishek
Kshitij-Katiyar Aug 24, 2023
4f79ae0
[MI-3230]: Developed a modal which opens on click of view button in c…
Kshitij-Katiyar Sep 1, 2023
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 1 addition & 4 deletions plugin.json
Original file line number Diff line number Diff line change
Expand Up @@ -25,10 +25,7 @@
{
"key": "ExistingConfigurationTable",
"display_name": "Existing Configurations:",
"type": "custom",
"help_text": "",
"placeholder": "",
"default": ""
"type": "custom"
}
]
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -4,11 +4,10 @@ import Modal from 'react-bootstrap/Modal';

import './styles.css';
Kshitij-Katiyar marked this conversation as resolved.
Show resolved Hide resolved

const AttachmentMsgModal = () => {
const AttachmentMessageModal = () => {
const [show, setShow] = useState(false);
const handleClose = () => {
setShow(false);
};
const handleClose = () => setShow(false);

return (
<>
<div
Expand Down Expand Up @@ -38,4 +37,4 @@ const AttachmentMsgModal = () => {
);
};

export default AttachmentMsgModal;
export default AttachmentMessageModal;
1 change: 0 additions & 1 deletion webapp/src/containers/components/modals/styles.css
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
.show {
display: block;
position: initial;
}
21 changes: 9 additions & 12 deletions webapp/src/containers/components/tables/existingConfigTable.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -14,8 +14,6 @@ type HelpText = {
isMarkdown: boolean;
isTranslated: boolean;
text: string;
textDefault?: string;
textValues?: string;
}
}

Expand All @@ -28,11 +26,10 @@ type Props = {

const ExistingConfigTable = ({label, helpText}: Props) => {
const [visible, setVisible] = useState(false);
const handleView = () => {
setVisible(true);
};
const handleView = () => setVisible(true);

return (
<div>
<>
<FormGroup>
<Col sm={4}>
{label}
Expand All @@ -53,7 +50,7 @@ const ExistingConfigTable = ({label, helpText}: Props) => {
<td>{'Standup'}</td>
<td>{'4'}</td>
<td className='ellipsis'>
{'Hello to standup group sdhfvk.'}
{'Hello to standup group.'}
Kshitij-Katiyar marked this conversation as resolved.
Show resolved Hide resolved
</td>
<td>
<Button
Expand Down Expand Up @@ -106,12 +103,12 @@ const ExistingConfigTable = ({label, helpText}: Props) => {
</Button>
</td>
<td>
<div>
<>
<ButtonGroup aria-label='Basic example'>
<Button variant='primary'>{'Edit'}</Button>
<Button variant='danger'>{'Delete'}</Button>
</ButtonGroup>
</div>
</>
</td>
</tr>
<tr>
Expand All @@ -127,12 +124,12 @@ const ExistingConfigTable = ({label, helpText}: Props) => {
</Button>
</td>
<td>
<div>
<>
<ButtonGroup aria-label='Basic example'>
<Button variant='primary'>{'Edit'}</Button>
<Button variant='danger'>{'Delete'}</Button>
</ButtonGroup>
</div>
</>
</td>
</tr>
</tbody>
Expand All @@ -144,7 +141,7 @@ const ExistingConfigTable = ({label, helpText}: Props) => {
</div>
</Col>
</FormGroup>
</div>
</>
);
};

Expand Down
4 changes: 2 additions & 2 deletions webapp/src/containers/components/tables/styles.css
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
table.table tbody tr td,
table.table thead tr th,
table.table thead {
border: 2px solid #ddd;
border: 2px solid #dddddd;
}

.table td {
Expand All @@ -24,5 +24,5 @@ table {
}
Kshitij-Katiyar marked this conversation as resolved.
Show resolved Hide resolved

.table thead tr th td{
white-space:nowrap
white-space: nowrap
}