Skip to content

Commit

Permalink
[MA-26]: Fix ARIA roles, states, and properties are valid in user pro…
Browse files Browse the repository at this point in the history 
…file image and @user buttons
  • Loading branch information
@SaurabhSharma-884
SaurabhSharma-884 committed Dec 16, 2024
1 parent d316df6 commit 213dbad
Show file tree
Hide file tree
Showing 9 changed files with 308 additions and 314 deletions.
116 changes: 52 additions & 64 deletions .../src/components/admin_console/admin_user_card/__snapshots__/admin_user_card.test.tsx.snap
View file
Original file line number Diff line number Diff line change
Expand Up @@ -8,26 +8,23 @@ exports[`components/admin_console/admin_user_card/admin_user_card should match d
<div
class="AdminUserCard__header"
>
<span
<button
aria-expanded="false"
aria-haspopup="dialog"
class="status-wrapper admin-user-card"
class="status-wrapper style--none admin-user-card"
style="border-radius: 50%; width: 128px; height: 128px;"
>
<button
class="RoundButton-dvlhqG gnYSKj style--none"
<span
class="profile-icon "
>
<span
class="profile-icon "
>
<img
alt="user profile image"
class="Avatar Avatar-xxl"
loading="lazy"
src="/api/v4/users/1234/image"
/>
</span>
</button>
</span>
<img
alt="user profile image"
class="Avatar Avatar-xxl"
loading="lazy"
src="/api/v4/users/1234/image"
/>
</span>
</button>
<div
class="AdminUserCard__user-info"
>
Expand Down Expand Up @@ -69,26 +66,23 @@ exports[`components/admin_console/admin_user_card/admin_user_card should match s
<div
class="AdminUserCard__header"
>
<span
<button
aria-expanded="false"
aria-haspopup="dialog"
class="status-wrapper admin-user-card"
class="status-wrapper style--none admin-user-card"
style="border-radius: 50%; width: 128px; height: 128px;"
>
<button
class="RoundButton-dvlhqG gnYSKj style--none"
<span
class="profile-icon "
>
<span
class="profile-icon "
>
<img
alt="user profile image"
class="Avatar Avatar-xxl"
loading="lazy"
src="/api/v4/users/1234/image"
/>
</span>
</button>
</span>
<img
alt="user profile image"
class="Avatar Avatar-xxl"
loading="lazy"
src="/api/v4/users/1234/image"
/>
</span>
</button>
<div
class="AdminUserCard__user-info"
>
Expand Down Expand Up @@ -125,26 +119,23 @@ exports[`components/admin_console/admin_user_card/admin_user_card should match s
<div
class="AdminUserCard__header"
>
<span
<button
aria-expanded="false"
aria-haspopup="dialog"
class="status-wrapper admin-user-card"
class="status-wrapper style--none admin-user-card"
style="border-radius: 50%; width: 128px; height: 128px;"
>
<button
class="RoundButton-dvlhqG gnYSKj style--none"
<span
class="profile-icon "
>
<span
class="profile-icon "
>
<img
alt="user profile image"
class="Avatar Avatar-xxl"
loading="lazy"
src="/api/v4/users/1234/image"
/>
</span>
</button>
</span>
<img
alt="user profile image"
class="Avatar Avatar-xxl"
loading="lazy"
src="/api/v4/users/1234/image"
/>
</span>
</button>
<div
class="AdminUserCard__user-info"
>
Expand Down Expand Up @@ -179,26 +170,23 @@ exports[`components/admin_console/admin_user_card/admin_user_card should match s
<div
class="AdminUserCard__header"
>
<span
<button
aria-expanded="false"
aria-haspopup="dialog"
class="status-wrapper admin-user-card"
class="status-wrapper style--none admin-user-card"
style="border-radius: 50%; width: 128px; height: 128px;"
>
<button
class="RoundButton-dvlhqG gnYSKj style--none"
<span
class="profile-icon "
>
<span
class="profile-icon "
>
<img
alt="user profile image"
class="Avatar Avatar-xxl"
loading="lazy"
src="/api/v4/users/1234/image"
/>
</span>
</button>
</span>
<img
alt="user profile image"
class="Avatar Avatar-xxl"
loading="lazy"
src="/api/v4/users/1234/image"
/>
</span>
</button>
<div
class="AdminUserCard__user-info"
>
Expand Down
174 changes: 78 additions & 96 deletions ...omponents/admin_console/system_user_detail/__snapshots__/system_user_detail.test.tsx.snap
View file
Original file line number Diff line number Diff line change
Expand Up @@ -28,26 +28,23 @@ exports[`SystemUserDetail should match default snapshot 1`] = `
<div
class="AdminUserCard__header"
>
<span
<button
aria-expanded="false"
aria-haspopup="dialog"
class="status-wrapper admin-user-card"
class="status-wrapper style--none admin-user-card"
style="border-radius: 50%; width: 128px; height: 128px;"
>
<button
class="RoundButton-dvlhqG gnYSKj style--none"
<span
class="profile-icon "
>
<span
class="profile-icon "
>
<img
alt="user profile image"
class="Avatar Avatar-xxl"
loading="lazy"
src="/api/v4/users/user_id/image"
/>
</span>
</button>
</span>
<img
alt="user profile image"
class="Avatar Avatar-xxl"
loading="lazy"
src="/api/v4/users/user_id/image"
/>
</span>
</button>
<div
class="AdminUserCard__user-info"
>
Expand Down Expand Up @@ -240,26 +237,23 @@ exports[`SystemUserDetail should match snapshot if MFA is enabled 1`] = `
<div
class="AdminUserCard__header"
>
<span
<button
aria-expanded="false"
aria-haspopup="dialog"
class="status-wrapper admin-user-card"
class="status-wrapper style--none admin-user-card"
style="border-radius: 50%; width: 128px; height: 128px;"
>
<button
class="RoundButton-dvlhqG gnYSKj style--none"
<span
class="profile-icon "
>
<span
class="profile-icon "
>
<img
alt="user profile image"
class="Avatar Avatar-xxl"
loading="lazy"
src="/api/v4/users/user_id/image"
/>
</span>
</button>
</span>
<img
alt="user profile image"
class="Avatar Avatar-xxl"
loading="lazy"
src="/api/v4/users/user_id/image"
/>
</span>
</button>
<div
class="AdminUserCard__user-info"
>
Expand Down Expand Up @@ -452,26 +446,23 @@ exports[`SystemUserDetail should not show manage user settings button when user
<div
class="AdminUserCard__header"
>
<span
<button
aria-expanded="false"
aria-haspopup="dialog"
class="status-wrapper admin-user-card"
class="status-wrapper style--none admin-user-card"
style="border-radius: 50%; width: 128px; height: 128px;"
>
<button
class="RoundButton-dvlhqG gnYSKj style--none"
<span
class="profile-icon "
>
<span
class="profile-icon "
>
<img
alt="user profile image"
class="Avatar Avatar-xxl"
loading="lazy"
src="/api/v4/users/user_id/image"
/>
</span>
</button>
</span>
<img
alt="user profile image"
class="Avatar Avatar-xxl"
loading="lazy"
src="/api/v4/users/user_id/image"
/>
</span>
</button>
<div
class="AdminUserCard__user-info"
>
Expand Down Expand Up @@ -664,26 +655,23 @@ exports[`SystemUserDetail should show manage user settings button as activated 1
<div
class="AdminUserCard__header"
>
<span
<button
aria-expanded="false"
aria-haspopup="dialog"
class="status-wrapper admin-user-card"
class="status-wrapper style--none admin-user-card"
style="border-radius: 50%; width: 128px; height: 128px;"
>
<button
class="RoundButton-dvlhqG gnYSKj style--none"
<span
class="profile-icon "
>
<span
class="profile-icon "
>
<img
alt="user profile image"
class="Avatar Avatar-xxl"
loading="lazy"
src="/api/v4/users/user_id/image"
/>
</span>
</button>
</span>
<img
alt="user profile image"
class="Avatar Avatar-xxl"
loading="lazy"
src="/api/v4/users/user_id/image"
/>
</span>
</button>
<div
class="AdminUserCard__user-info"
>
Expand Down Expand Up @@ -881,26 +869,23 @@ exports[`SystemUserDetail should show manage user settings button as disabled wh
<div
class="AdminUserCard__header"
>
<span
<button
aria-expanded="false"
aria-haspopup="dialog"
class="status-wrapper admin-user-card"
class="status-wrapper style--none admin-user-card"
style="border-radius: 50%; width: 128px; height: 128px;"
>
<button
class="RoundButton-dvlhqG gnYSKj style--none"
<span
class="profile-icon "
>
<span
class="profile-icon "
>
<img
alt="user profile image"
class="Avatar Avatar-xxl"
loading="lazy"
src="/api/v4/users/user_id/image"
/>
</span>
</button>
</span>
<img
alt="user profile image"
class="Avatar Avatar-xxl"
loading="lazy"
src="/api/v4/users/user_id/image"
/>
</span>
</button>
<div
class="AdminUserCard__user-info"
>
Expand Down Expand Up @@ -1093,26 +1078,23 @@ exports[`SystemUserDetail should show the activate user button as disabled when
<div
class="AdminUserCard__header"
>
<span
<button
aria-expanded="false"
aria-haspopup="dialog"
class="status-wrapper admin-user-card"
class="status-wrapper style--none admin-user-card"
style="border-radius: 50%; width: 128px; height: 128px;"
>
<button
class="RoundButton-dvlhqG gnYSKj style--none"
<span
class="profile-icon "
>
<span
class="profile-icon "
>
<img
alt="user profile image"
class="Avatar Avatar-xxl"
loading="lazy"
src="/api/v4/users/user_id/image"
/>
</span>
</button>
</span>
<img
alt="user profile image"
class="Avatar Avatar-xxl"
loading="lazy"
src="/api/v4/users/user_id/image"
/>
</span>
</button>
<div
class="AdminUserCard__user-info"
>
Expand Down
Loading

0 comments on commit 213dbad

Please sign in to comment.