New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MA-18]: Added dialog role to the emoji picker #19

Open

ayush-chauhan233 wants to merge 1 commit into master from ma_18/issue_mm_61612

Collaborator

ayush-chauhan233 commented Dec 13, 2024

Summary

Added dialog role to the emoji picker.
Added ARIA properties such as aria-label and aria-modal to the emoji picker.

Steps to reproduce

Locate the Emoji Picker dialog.
Inspect it with Chrome DevTools.
In the Accessibility tab, expand the Computed Properties section.
Review the values for "Name" and "Role".

Expected Behavior

Dialog containers must have role="dialog". If the dialog has a visible title, set aria-labelledby on the dialog container to the ID of the visible title. For dialogs without a visible title, set a descriptive aria-label on the dialog element.

Ticket Link

Jira https://mattermost.atlassian.net/browse/MM-61612

Screenshots

Before	After

Release Note

NONE


          [MA-18]: Added dialog role to the emoji picker

2e58fe1

ayush-chauhan233 requested a review from SaurabhSharma-884

December 13, 2024 08:41

ayush-chauhan233 self-assigned this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet