Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BST-183]: Removed unnecessary role and aria-level from channel header #3

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[BST-183]: Removed unnecessary role and aria-level from channel header #3

wants to merge 1 commit into from

Conversation

ayush-chauhan233
Copy link
Collaborator

@ayush-chauhan233 ayush-chauhan233 commented Nov 28, 2024 •
edited
Loading

Summary

  • Removed unnecessary aria-level={2} and role="heading" from Channel header title

Steps to reproduce

  • Locate the Town Square text marked as a heading.
  • Inspect it with Chrome DevTools.
  • Notice that the text uses role="heading".

Expected Behavior

  • Remove role="heading" and aria-level="2" from the tag having class="heading".

Ticket Link

Jira https://mattermost.atlassian.net/browse/MM-61652

Screenshots

Before After

Release Note

NONE

@ayush-chauhan233 ayush-chauhan233 self-assigned this Nov 28, 2024
@ayush-chauhan233 ayush-chauhan233 changed the base branch from release-10.2 to master December 9, 2024 07:13
@ayush-chauhan233 ayush-chauhan233 force-pushed the bst_183/issue_mm_61652 branch 3 times, most recently from e339708 to 0ab8aeb Compare December 9, 2024 07:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SaurabhSharma-884 SaurabhSharma-884 SaurabhSharma-884 approved these changes

@avas27JTG avas27JTG avas27JTG approved these changes

Assignees

@ayush-chauhan233 ayush-chauhan233

Labels
On External
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ayush-chauhan233 @avas27JTG @SaurabhSharma-884