Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BST-185]: Fixed the aria-roles and plugins preferences tab list structure. #5

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

[BST-185]: Fixed the aria-roles and plugins preferences tab list structure. #5

wants to merge 2 commits into from

Conversation

ayush-chauhan233
Copy link
Collaborator

@ayush-chauhan233 ayush-chauhan233 commented Nov 29, 2024 •
edited
Loading

Summary

  • Updated the Plugin preferences tab list structure in the user settings modal.
  • Updated the aria-level and aria-role for the plugin's preferences heading.

Steps to reproduce

  • Navigate to the PLUGIN PREFERENCES heading text.
  • Inspect the element.
  • Notice that the aria-level attribute is not provided for the role="heading".

Expected Behavior

  • Plugin preferences must be in a separate region with its tab list.

Ticket Link

Jira https://mattermost.atlassian.net/browse/MM-61648

Screenshots

Before After

Release Note

NONE

@ayush-chauhan233 ayush-chauhan233 self-assigned this Nov 29, 2024
@ayush-chauhan233 ayush-chauhan233 changed the base branch from release-10.2 to master December 9, 2024 07:38
@SaurabhSharma-884 SaurabhSharma-884 added the Approved Dev approved, ready to be reviewed by MM team label Jan 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@avas27JTG avas27JTG avas27JTG approved these changes

@SaurabhSharma-884 SaurabhSharma-884 SaurabhSharma-884 approved these changes

Assignees

@ayush-chauhan233 ayush-chauhan233

Labels
Approved Dev approved, ready to be reviewed by MM team On External
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ayush-chauhan233 @avas27JTG @SaurabhSharma-884