Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BST-189]: Fixed autofocus on submenu's first element #6

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

[BST-189]: Fixed autofocus on submenu's first element #6

wants to merge 2 commits into from

Conversation

ayush-chauhan233
Copy link
Collaborator

@ayush-chauhan233 ayush-chauhan233 commented Nov 29, 2024 •
edited
Loading

Summary

  • Fixed autofocus of the first menu item in submenu using Popover to render the submenu.
  • Added a sub-menu header prop to render the header ReactNode.
  • Initially, the header was restricting the autofocus on the first element, Hence, refactored it with the MUI popover component.
  • Updated the test case and test snapshots as well as needed.

Steps to reproduce

  • Tab to the ••• icon on any message
  • Press DOWN with the keyboard until you get to the Remind menu item
  • press RIGHT to open the submenu

Expected Behavior

  • Sub-menu's first element must autofocus when the sub-menu opens.

Ticket Link

Jira https://mattermost.atlassian.net/browse/MM-55278

Screenshots

Before After

Release Note

NONE

@ayush-chauhan233 ayush-chauhan233 self-assigned this Nov 29, 2024
SaurabhSharma-884
SaurabhSharma-884 approved these changes Dec 6, 2024
View reviewed changes
webapp/channels/src/components/menu/sub_menu.tsx Outdated
Comment on lines 183 to 184
paddingTop: 0,
paddingBottom: 0,
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
paddingTop: 0,
paddingBottom: 0,
py:0

@ayush-chauhan233 ayush-chauhan233 changed the base branch from release-10.2 to master December 9, 2024 07:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SaurabhSharma-884 SaurabhSharma-884 SaurabhSharma-884 approved these changes

@avas27JTG avas27JTG avas27JTG approved these changes

Assignees

@ayush-chauhan233 ayush-chauhan233

Labels
On External
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ayush-chauhan233 @avas27JTG @SaurabhSharma-884