Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MA-7]: Refactored the post priority menu and fixed the keyboard navigation issue in the menu. #8

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

ayush-chauhan233
Copy link
Collaborator

@ayush-chauhan233 ayush-chauhan233 commented Dec 3, 2024

Summary

  • Refactored the post-priority menu, removed the deprecated code, and fixed the keyboard navigation issue.
  • Updated the menu component to accept a menu header as well as a menu footer.
  • Updated the menu item role to menuitemcheckbox and menuitemradio and added appropriate roles to the menu.

Steps to reproduce

  • Navigate to the Message priority button and select it.
  • Notice that after selecting the Message priority button, the keyboard focus does not move on the dialog and also does not return to the triggered element.

Expected behavior

  • As the menu opens it should auto-focus on the first menu item as well as all the other menu items should be keyboard accessible.

Ticket Link

Jira https://mattermost.atlassian.net/browse/MM-61570

Screenshots

Before After

Release Note

- A minor change in the message priority checkbox menu item, the description width is smaller than the previous version.

@ayush-chauhan233 ayush-chauhan233 self-assigned this Dec 3, 2024
@ayush-chauhan233 ayush-chauhan233 changed the base branch from release-10.2 to master December 9, 2024 07:44
@ayush-chauhan233 ayush-chauhan233 force-pushed the ma_7/issue_mm_61570 branch 2 times, most recently from 08786b7 to 185c67b Compare December 9, 2024 09:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants