D2LXXXX: ban default constructor of certain structs #510
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
omsmith
commented
Jun 19, 2019
j3parker
reviewed
Jun 19, 2019
| GeneratedCodeAnalysisFlags.None | ||
| ); | ||
|
|
||
| context.RegisterOperationAction( |
There was a problem hiding this comment.
Might want to handle = default( T ) at some point
There was a problem hiding this comment.
From IRL: = default( T ) is pretty explicit so maybe don't ban it.
j3parker
reviewed
Jun 19, 2019
src/D2L.CodeStyle.Analyzers/Language/DefaultStructCreation/DefaultStructCreationAnalyzer.cs
Show resolved
Hide resolved
j3parker
approved these changes
Jun 19, 2019
omsmith
force-pushed
the
omsmith/dont-call-default-struct-constructor
branch
from
b254c4d to
2611ff8
Compare
omsmith
changed the title
omsmith
force-pushed
the
omsmith/dont-call-default-struct-constructor
branch
from
2611ff8 to
456187f
Compare
j3parker
reviewed
Jun 19, 2019
src/D2L.CodeStyle.Analyzers/Language/DefaultStructCreation/DefaultStructCreationAnalyzer.cs
Outdated
Show resolved
Hide resolved
j3parker
reviewed
Jun 19, 2019
src/D2L.CodeStyle.Analyzers/Language/DefaultStructCreation/DefaultStructCreationAnalyzer.cs
Show resolved
Hide resolved
j3parker
previously approved these changes
Jun 19, 2019
This is a generic version of, and supercedes D2L0029. Includes codefixes to use the initializer for the likely-to-be-intended usecase. This may be a miss for some things, such as Guid.Empty vs Guid.NewGuid(). Could theoretically suggest both.
omsmith
force-pushed
the
omsmith/dont-call-default-struct-constructor
branch
from
456187f to
12e41c4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a generic version of, and supercedes D2L0029.
Includes codefixes to use the initializer for the likely-to-be-intended
usecase. This may be a miss for some things, such as Guid.Empty vs
Guid.NewGuid(). Could theoretically suggest both.