Default to .NET Standard 2.0 for all projects #955
+2
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Moving this to the default because it makes sense: "annotations"-style DLLs we ship should probably target that for simplicity (the existing Annotations DLL also multi-targets net20 which we can probably drop?), and the analyzers have to target netstandard2.0. Our test projects will need to override this; currently we run our tests in net48 for some reason, but we should target net7/8/etc. I think. Overall I think this will keep the csproj's simpler, especially once I split the packages.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moving this to the default because it makes sense: "annotations"-style DLLs we ship should probably target that for simplicity (the existing Annotations DLL also multi-targets net20 which we can probably drop?), and the analyzers have to target netstandard2.0.
Our test projects will need to override this; currently we run our tests in net48 for some reason, but we should target net7/8/etc. I think.
Overall I think this will keep the csproj's simpler, especially once I split the packages.