add '--use-credential-process' to write command #443
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cfbao
force-pushed
the
use-credential-process
branch
from
6c631d6 to
28d3525
Compare
cfbao
requested review from
tmanti,
boarnoah,
scowing,
jharoutuniand2l and
gord5500
boarnoah
reviewed
Jan 17, 2024
| public const string Format = "Output format of AWS credentials"; | ||
| public const string NonInteractive = "Run non-interactively without showing any prompts"; | ||
| public const string CacheAwsCredentials = "Enables Cache for AWS tokens"; | ||
| public const string CacheAwsCredentials = | ||
| "Enables Cache for AWS tokens. Implied if '--use-credential-process' is supplied"; |
There was a problem hiding this comment.
It does make the bit about --cache a little confusing if the recommend way to start using bmx in credential process is to use -use-credential-process
Should we keep the flag but just not document it, suggest it should always be used indirectly.
There was a problem hiding this comment.
I think we can omit talking about it in the README, if that's what you mean.
But I think it's worth documenting all the flags in the CLI binary's help text for power users.
e.g. we use it here: https://github.com/Brightspace/vulcan-scratch/blob/0c8e6d00229339d9108240c03bb6602fdbba9705/slims/helper_scripts/lib/Invoke-AuthTokenRestMethod.psm1#L38
boarnoah
approved these changes
Jan 17, 2024
gord5500
approved these changes
Jan 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make it easier for people to start using BMX in
credential_process, and reduce user errors.https://d2l.slack.com/archives/G4P099831/p1705333949277619