remove AWS credential provider settings on bmx write
#461
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cfbao
commented
Jul 19, 2024
Comment on lines
-138
to
+137
| return File.Exists( path ) ? parser.ReadFile( path ) : null; | ||
| return File.Exists( path ) ? parser.ReadFile( path, Utf8 ) : null; |
There was a problem hiding this comment.
unrelated - the default encoding is ASCII - what if I want to write Chinese comments in my AWS config file
There was a problem hiding this comment.
Huh, I figured C# is for the most part UTF8 by default in places? Or is it just the FileSystem API that is like this?
> System.Text.Encoding.Default
UTF8Encoding.UTF8EncodingSealed
There was a problem hiding this comment.
There was a problem hiding this comment.
It'd be disastrous if C#/.NET runtime did this.
There was a problem hiding this comment.
👍 I suppose that makes sense for them. INI doesn't have a spec around it and it could be used by old timey things that except files to be ASCII?
There was a problem hiding this comment.
I don't think it makes sense at all actually. UTF-8 is ASCII compatible.
cfbao
requested review from
boarnoah,
scowing,
jharoutuniand2l,
jkomonen and
gord5500
boarnoah
approved these changes
Jul 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
An AWS profile can only have one credential provider configured.
Not removing other credential providers' settings when
bmx writeruns could lead to a broken or at least confusing AWS profile.Ticket
https://desire2learn.atlassian.net/browse/VUL-402