tweak release workflow #490
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area/github-actions
size/XS
cfbao
force-pushed
the
no-auto-publish
branch
from
4e8e578 to
8b49811
Compare
github-actions
bot
added
size/S
gord5500
approved these changes
Oct 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We never published a release automatically, and I don't think we ever should.
We need to manually edit and review the release, and test the to-be-released binaries (as opposed to testing binaries built from another CI run or even locally).
So I've changed the workflow to keep (non-pre-)releases as draft.
I'd like prereleases to all look like prereleases.
The current process doesn't enforce that you must include words like "preview", "beta" when you publish a prerelease. This can be confusing. I've made the workflow auto append "-preview-{datetime}" to the version/tag name for prereleases.