Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

turn Browser non-static #491

Merged
merged 1 commit into from
Oct 22, 2024
Merged

turn Browser non-static #491

merged 1 commit into from
Oct 22, 2024

Conversation

cfbao
Copy link
Member

@cfbao cfbao commented Oct 22, 2024

nit: such side-effect heavy and environment dependent operations should ideally not be static

@cfbao cfbao marked this pull request as ready for review October 22, 2024 17:34
@cfbao cfbao requested a review from a team as a code owner October 22, 2024 17:34
@cfbao cfbao merged commit 779eb5a into main Oct 22, 2024
9 checks passed
@cfbao cfbao deleted the browser-tweak branch October 22, 2024 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@scowing scowing scowing approved these changes

@boarnoah boarnoah Awaiting requested review from boarnoah boarnoah is a code owner automatically assigned from Brightspace/vulcan

@AnimalXing AnimalXing Awaiting requested review from AnimalXing AnimalXing is a code owner automatically assigned from Brightspace/vulcan

@gord5500 gord5500 Awaiting requested review from gord5500 gord5500 is a code owner automatically assigned from Brightspace/vulcan

Assignees
No one assigned
Labels
language/csharp size/S A small PR.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cfbao @scowing