Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Test on Node 20 #115

Merged
merged 1 commit into from
Apr 10, 2024
Merged

chore: Test on Node 20 #115

merged 1 commit into from
Apr 10, 2024

Conversation

oelhanafey
Copy link
Contributor

@oelhanafey oelhanafey commented Apr 8, 2024 •
edited by jira bot
Loading

LURV-1665

This repo does not use library-ci. It was already on Node 18 but was not testing for Node 20 so this PR adds support for Node 20.

AntonBazhal
AntonBazhal reviewed Apr 9, 2024
View reviewed changes
Copy link
Contributor

@AntonBazhal AntonBazhal left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. You'll also need to update required checks. NVM, I see your PR for that.

@oelhanafey oelhanafey marked this pull request as ready for review April 10, 2024 13:12
@oelhanafey oelhanafey requested a review from a team as a code owner April 10, 2024 13:12
@oelhanafey oelhanafey merged commit 52aa60b into master Apr 10, 2024
4 checks passed
@oelhanafey oelhanafey deleted the oelhanafey/node-version branch April 10, 2024 14:37
@d2l-github-release-tokens D2L GitHub Release Tokens
Copy link

🎉 This PR is included in version 3.1.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AntonBazhal AntonBazhal AntonBazhal approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@oelhanafey @AntonBazhal