Fix lint errors

.editorconfig

@@ -0,0 +1,26 @@
+# http://EditorConfig.org
+
+# top-most EditorConfig file
+root = true
+
+[*]
+charset = "utf8"
+
+
+[*.css]
+indent_style = space
+indent_size = 4
+trim_trailing_whitespace = true
+
+
+[*.js]
+indent_style = space
+indent_size = 4
+trim_trailing_whitespace = true
+quote_type = double
+
+
+[*.json]
+indent_style = space
+indent_size = 2
+trim_trailing_whitespace = true

.jshintrc

@@ -0,0 +1,33 @@
+{
+  "curly": true,
+  "eqeqeq": true,
+  "immed": true,
+  "laxbreak": false,
+  "latedef": "nofunc",
+  "newcap": true,
+  "noarg": true,
+  "plusplus": true,
+  "sub": true,
+  "undef": true,
+  "quotmark": "double",
+  "unused": true,
+  "indent": 4,
+  "eqnull": true,
+  "node": true,
+  "strict": false,
+  "mocha": true,
+  "jasmine": true,
+  "globals": {
+    "window": false,
+    "browser": false,
+    "sinon": false,
+    "___browserSync___": false,
+    "assert": false,
+    "by": false,
+    "element": false,
+    "protractor": false,
+    "assert": false,
+    "inject": false,
+    "angular": false
+  }
+}

gulpfile.js

@@ -2,15 +2,13 @@ var gulp        = require("gulp");
 var jshint      = require("gulp-jshint");
 var contribs    = require("gulp-contribs");
 var sass        = require("gulp-sass");
-var fs          = require("fs");
 var autoprefix  = require("gulp-autoprefixer");
 var browserify  = require("gulp-browserify");
 var rename      = require("gulp-rename");
 var filter      = require("gulp-filter");
 var sprites     = require("gulp-svg-sprites");
 var browserSync = require("browser-sync");
 var crossbow    = require("crossbow/plugins/stream");
-var reload      = browserSync.reload;
 
 /**
  * Lint all JS files
@@ -24,10 +22,10 @@ gulp.task("lint", function () {
         "server/*.js",
         "gulpfile.js",
     ])
-    .pipe(require("no-abs")());
-    //.pipe(jshint("test/.jshintrc"))
-    //.pipe(jshint.reporter("default"))
-    //.pipe(jshint.reporter("fail"));
+    .pipe(require("no-abs")())
+    .pipe(jshint(".jshintrc"))
+    .pipe(jshint.reporter("default"))
+    .pipe(jshint.reporter("fail"));
 });
 
 /**
@@ -150,4 +148,3 @@ gulp.task("dev", ["browserify"], function () {
     gulp.watch("lib/scss/**/*.scss", ["sass"]);
     gulp.watch("lib/js/scripts/**/*.js", ["browserify"]);
 });
-

index.js

@@ -1,7 +1,5 @@
 "use strict";
 
-var path        = require("path");
-
 var EE          = require("easy-extender");
 
 var async       = require("./server/async");
@@ -48,7 +46,7 @@ var ControlPanel = function (opts, bs, emitter) {
 ControlPanel.prototype.getServer = function (cb) {
     var cp = this;
     if (!cp.server) {
-        this.events.on("cp:running", function (out) {
+        this.events.on("cp:running", function () {
             cb(null, cp.server);
         });
     }
@@ -110,7 +108,7 @@ ControlPanel.prototype.init = function () {
             cp.logger.debug("{green:Step Complete: " + item.step);
             cb();
         });
-    }, function (err) {
+    }, function () {
         cp.events.emit("cp:running", {instance: cp, options: cp.opts});
         cp.logger.info("Running at: {cyan:http://localhost:%s", cp.opts.get("port"));
     });

lib/js/dist/app.js

@@ -73,7 +73,7 @@ function MainCtrl ($$scope, $rootScope, $location, Socket, $injector) {
         /**
          * @param options
          */
-        connection: function (options, socket) {
+        connection: function (options) {
 
             // TODO: Add socket tracking.
             //if (socket) {
@@ -84,7 +84,7 @@ function MainCtrl ($$scope, $rootScope, $location, Socket, $injector) {
         /**
          *
          */
-        disconnect: function (data) {
+        disconnect: function () {
             $scope.ui.disconnected = true;
         }
     };
@@ -226,7 +226,7 @@ module.directive("markable", function () {
     return {
         scope: {},
         restrict: "A",
-        link: function (scope, elem, attrs) {
+        link: function () {
             //var click = function (evt) {
             //    elem.toggleClass("active");
             //};
@@ -257,14 +257,14 @@ module.exports = app;
  * Custom Notify module for Global notifications
  *
  */
-angular.module('Disconnect', [])
+angular.module("Disconnect", [])
 
     .directive("disconnectElem", function () {
 
         return {
             restrict: "E",
             scope: {},
-            template: '<section bs-Overlay ng-class="{\'active\': ui.visible}"><p><i bs-Icon="block" bs-Icon-Size="jumbo"></i></p><h1 bs-Weight="light">{{ui.heading}} {{ui.message}}</h1><p>Possible reasons are:</p><ul bs-List><li>1. Your process was exited by another tool</li></ul></section>',
+            template: '<section bs-Overlay ng-class="{\'active\': ui.visible}"><p><i bs-Icon="block" bs-Icon-Size="jumbo"></i></p><h1 bs-Weight="light">{{ui.heading}} {{ui.message}}</h1><p>Possible reasons are:</p><ul bs-List><li>1. Your process was exited by another tool</li></ul></section>', // jshint:ignore
             controller: ["$scope", "$rootScope", "$window", disconnectController]
         };
     });

lib/js/scripts/MainCtrl.js

@@ -72,7 +72,7 @@ function MainCtrl ($$scope, $rootScope, $location, Socket, $injector) {
         /**
          * @param options
          */
-        connection: function (options, socket) {
+        connection: function (options) {
 
             // TODO: Add socket tracking.
             //if (socket) {
@@ -83,7 +83,7 @@ function MainCtrl ($$scope, $rootScope, $location, Socket, $injector) {
         /**
          *
          */
-        disconnect: function (data) {
+        disconnect: function () {
             $scope.ui.disconnected = true;
         }
     };

lib/js/scripts/filters.js

@@ -36,7 +36,7 @@ module.directive("markable", function () {
     return {
         scope: {},
         restrict: "A",
-        link: function (scope, elem, attrs) {
+        link: function () {
             //var click = function (evt) {
             //    elem.toggleClass("active");
             //};

lib/js/scripts/modules/disconnect.js

@@ -3,14 +3,14 @@
  * Custom Notify module for Global notifications
  *
  */
-angular.module('Disconnect', [])
+angular.module("Disconnect", [])
 
     .directive("disconnectElem", function () {
 
         return {
             restrict: "E",
             scope: {},
-            template: '<section bs-Overlay ng-class="{\'active\': ui.visible}"><p><i bs-Icon="block" bs-Icon-Size="jumbo"></i></p><h1 bs-Weight="light">{{ui.heading}} {{ui.message}}</h1><p>Possible reasons are:</p><ul bs-List><li>1. Your process was exited by another tool</li></ul></section>',
+            template: '<section bs-Overlay ng-class="{\'active\': ui.visible}"><p><i bs-Icon="block" bs-Icon-Size="jumbo"></i></p><h1 bs-Weight="light">{{ui.heading}} {{ui.message}}</h1><p>Possible reasons are:</p><ul bs-List><li>1. Your process was exited by another tool</li></ul></section>', // jshint:ignore
             controller: ["$scope", "$rootScope", "$window", disconnectController]
         };
     });

package.json

@@ -79,3 +79,4 @@
   },
   "keywords": []
 }
+

server/hooks.js

@@ -1,4 +1,3 @@
-var _          = require("lodash");
 var fs         = require("fs");
 var path       = require("path");
 var tmpl       = fs.readFileSync(__dirname + "/templates/plugin.tmpl", "utf-8");
@@ -40,7 +39,7 @@ module.exports = {
         return configTmpl.replace("%when%", items)
             .replace("%pages%", JSON.stringify(pagesConfig, null, 4));
     },
-    "markup": function (hooks, initial) {
+    "markup": function (hooks) {
         var out = hooks.reduce(function (combined, item) {
             return [combined, tmpl.replace("%markup%", item)].join("\n");
         }, "");
@@ -49,7 +48,7 @@ module.exports = {
     "client:js": function (hooks) {
         return hooks.join(";");
     },
-    "templates": function (hooks, cb) {
+    "templates": function (hooks) {
 
         var inlineTemplates = createInlineTemplates(hooks);
         return inlineTemplates;

server/opts.js

@@ -1,5 +1,5 @@
 var Immutable  = require("immutable");
-var transforms = require("./transforms");
+//var transforms = require("./transforms");
 
 var defaults = Immutable.Map({
     port: 3001
@@ -17,13 +17,13 @@ module.exports.merge = function (obj) {
  * @param {Immutable.Map} obj
  * @returns {*}
  */
-function transformOptions(obj) {
-
-    var out;
-
-    Object.keys(transforms).forEach(function (key) {
-        out = obj.set(key, transforms[key](obj));
-    });
-
-    return out;
-}
+//function transformOptions(obj) {
+//
+//    var out;
+//
+//    Object.keys(transforms).forEach(function (key) {
+//        out = obj.set(key, transforms[key](obj));
+//    });
+//
+//    return out;
+//}

server/server.js

@@ -1,7 +1,5 @@
-var _           = require("lodash");
 var connect     = require("connect");
 var through     = require("through");
-var path        = require("path");
 var http        = require("http");
 var fs          = require("fs");
 var serveStatic = require("serve-static");

server/utils.js

@@ -1,4 +1,3 @@
-var path     = require("path");
 var url      = require("url");
 var http     = require("http");
 

test/.jshintrc

@@ -14,6 +14,7 @@
     "eqnull": true,
     "node": true,
     "validthis": true,
+    "mocha": true,
     "globals": {
         "describe" : false,
         "it" : false,

test/client/specs/directives/snippet-info.test.js

@@ -25,8 +25,8 @@ describe("Directive: Snippet info", function () {
         });
 
         it("Should be shown be default", function () {
-            var localScope = scope.$$childHead;
-//            assert.equal(localScope.ui.snippet, true);
+            //var localScope = scope.$$childHead;
+            //assert.equal(localScope.ui.snippet, true);
         });
     });
 });

test/client/specs/modules/disconnect.js

@@ -4,13 +4,11 @@ describe("When using the disconnect element", function () {
 
     var scope, element, compile;
 
-    var $window;
-
     beforeEach(module("BrowserSync"));
     beforeEach(module("test.templates"));
 
     // Initialize the controller and a mock scope
-    beforeEach(inject(function ($compile, $rootScope, _$window_) {
+    beforeEach(inject(function ($compile, $rootScope) {
         scope   = $rootScope;
         compile = $compile;
     }));

test/client/specs/modules/history.js

@@ -1,13 +1,11 @@
 describe("Module: History", function () {
 
-    var scope, element, compile, clock;
-
     beforeEach(module("BrowserSync"));
     beforeEach(module("test.templates"));
 
     describe("When using the history module", function () {
 
-        var Location, rootScope, isolatedScope, Socket;
+        var Location, rootScope, Socket;
         beforeEach(inject(function (_Location_, $rootScope, _Socket_, $q) {
             Location  = _Location_;
             Socket    = _Socket_;

test/client/specs/services/ContentSectionsSpec.js

@@ -12,7 +12,7 @@ describe("Content Sections Value/Service", function () {
         values = $injector.get("contentSections");
     }));
     it("should be able to transform a value", function () {
-        var transformed = sections.transform(values["history"], function (item) {
+        sections.transform(values["history"], function (item) {
             item.title = "Shane";
             return item;
         });

test/server/history.js

@@ -1,20 +1,21 @@
+/*jshint -W079 */
 var Immutable = require("immutable");
 var history   = require("../../server/plugins/history/history");
 var assert    = require("chai").assert;
 
 describe("Saving history", function () {
     it("Adding a new path", function () {
-        var imm = Immutable.OrderedSet('/');
+        var imm = Immutable.OrderedSet("/");
         var out = history.addPath(imm, "http://localhost/shane");
         assert.deepEqual(out.toJS(), ["/", "/shane"]);
     });
     it("Adding a dupe path", function () {
-        var imm = Immutable.OrderedSet('/');
+        var imm = Immutable.OrderedSet("/");
         var out = history.addPath(imm, "http://localhost/");
         assert.deepEqual(out.toJS(), ["/"]);
     });
     it("Can remove a path", function () {
-        var imm = Immutable.OrderedSet(['/', "/shane"]);
+        var imm = Immutable.OrderedSet(["/", "/shane"]);
         var out = history.removePath(imm, "http://localhost/");
         assert.deepEqual(out.toJS(), ["/shane"]);
     });

test/server/init.js

@@ -1,7 +1,7 @@
+/*jshint -W079 */
 var browserSync = require("browser-sync");
 var cp          = require("../../index");
 var assert      = require("chai").assert;
-var sinon       = require("sinon");
 var config      = require("../../server/config");
 var request     = require("supertest");
 
@@ -35,7 +35,7 @@ describe("Can be started with browserSync instance", function() {
         request(controlPanel.server)
             .get("/")
             .expect(200)
-            .end(function (err, res, req) {
+            .end(function (err, res) {
                 assert.include(res.text, "Browser Sync - Control Panel");
                 done();
             });
@@ -54,7 +54,7 @@ describe("Can be started with browserSync instance", function() {
         request(controlPanel.server)
             .get(config.defaults.appJs)
             .expect(200, function (err, res) {
-                assert.include(res.text, 'angular');
+                assert.include(res.text, "angular");
                 done();
             });
     });