Lint ALL lib/*.js files

.jshintrc

@@ -2,7 +2,7 @@
   "curly": true,
   "eqeqeq": true,
   "immed": true,
-  "laxbreak": false,
+  "laxbreak": true,
   "latedef": "nofunc",
   "newcap": true,
   "noarg": true,
@@ -18,6 +18,7 @@
   "browser": true,
   "mocha": true,
   "jasmine": true,
+  "esnext": true,
   "globals": {
     "browser": false,
     "sinon": false,

gulpfile.js

@@ -21,6 +21,7 @@ gulp.task("lint", function () {
     return gulp.src([
         "test/client/specs/**/*.js",
         "test/server/**/*.js",
+        "lib/**/*.js",
         "public/js/scripts/*.js",
         "index.js",
         "server/*.js",

lib/UI.js

@@ -1,5 +1,4 @@
 var config      = require("./config");
-var Immutable   = require("immutable");
 var eachSeries  = require("async-each-series");
 var asyncTasks  = require("./async-tasks");
 var hooks       = require("./hooks");

lib/client-elements.js

@@ -39,7 +39,7 @@ function enableElement (clients, ui, bs) {
  * @param bs
  * @returns {Function}
  */
-function disableElement (clients, ui, bs) {
+function disableElement (clients, ui) {
 
     return function (file) {
         var item = ui.getOptionIn([CLIENT_FILES_OPT, file.name]).toJS();

lib/client-js.js

@@ -4,7 +4,7 @@
 
     var socket = bs.socket;
 
-    socket.on("cp:connection", function (options) {
+    socket.on("cp:connection", function () {
 
         bs.socket.emit("cp:history:connected", {
             href: window.location.href,
@@ -30,7 +30,7 @@
         }
     });
 
-    socket.on("highlight", function (data) {
+    socket.on("highlight", function () {
         var id = "__browser-sync-highlight__";
         var elem = document.getElementById(id);
         if (elem) {
@@ -85,7 +85,9 @@
     }
 
     function removeElement(element) {
-        element && element.parentNode && element.parentNode.removeChild(element);
+        if (element && element.parentNode) {
+            element.parentNode.removeChild(element);
+        }
     }
 
 })(window, document, ___browserSync___);

lib/hooks.js

@@ -20,7 +20,7 @@ module.exports = {
      * @param cp
      * @param cb
      */
-    "page": function (hooks, cp, cb) {
+    "page": function (hooks, cp) {
 
         var config = hooks
             .map(transformConfig)

lib/plugins/connections/connections.plugin.js

@@ -1,7 +1,4 @@
-var urls      = require("../../urls");
-var url       = require("url");
 var path      = require("path");
-var fs        = require("fs");
 var Immutable = require("immutable");
 
 const PLUGIN_NAME = "Connections";
@@ -79,7 +76,6 @@ module.exports = {
 
         var registry;
         var temp;
-        var count = 0;
         var initialSent;
 
         setInterval(function () {
@@ -141,8 +137,8 @@ module.exports = {
  * @param data
  */
 function highlightClient (clients, data) {
-    var socket;
-    if (socket = getClientById(clients, data.id)) {
+    var socket = getClientById(clients, data.id);
+    if (socket) {
         socket.emit("highlight");
     }
 }

lib/plugins/help/help.plugin.js

@@ -1,8 +1,5 @@
-var urls      = require("../../urls");
-var url       = require("url");
 var path      = require("path");
 var fs        = require("fs");
-var Immutable = require("immutable");
 
 const PLUGIN_NAME = "Help / About";
 
@@ -11,12 +8,9 @@ const PLUGIN_NAME = "Help / About";
  */
 module.exports = {
     /**
-     * @param cp
-     * @param bs
+     * Plugin init
      */
-    "plugin": function (cp, bs) {
-        /* noop */
-    },
+    "plugin": function () {},
     /**
      * Hooks
      */

lib/plugins/history/history.js

@@ -1,7 +1,4 @@
-var urls      = require("../../urls");
 var url       = require("url");
-var path      = require("path");
-var fs        = require("fs");
 var Immutable = require("immutable");
 
 module.exports.init = function (ui, bs) {
@@ -79,7 +76,7 @@ module.exports.init = function (ui, bs) {
         cpClient.on("urls:browser:url",  methods.sendToUrl);
         cpClient.on("cp:get:visited",    methods.getVisited);
         cpClient.on("cp:history:remove", methods.removePath);
-        cpClient.on("cp:history:clear", function (data) {
+        cpClient.on("cp:history:clear", function () {
             validUrls = Immutable.OrderedSet([]);
             methods.sendUpdatedUrls(validUrls);
         });
@@ -94,7 +91,7 @@ module.exports.init = function (ui, bs) {
  */
 function decorateUrls (urls) {
     var count = 0;
-    return urls.map(function (value, i) {
+    return urls.map(function (value) {
         count += 1;
         return {
             path: value,
@@ -103,20 +100,6 @@ function decorateUrls (urls) {
     }).toJS().reverse();
 }
 
-/**
- * Send all browsers to a URL
- */
-function sendToUrl (cp, bs, clients, data) {
-
-    var parsed = url.parse(data.path);
-
-    data.override = true;
-    data.path = parsed.path;
-    data.url  = parsed.href;
-
-    clients.emit("browser:location", data);
-}
-
 /**
  * If snippet mode, add the full URL
  * if server/proxy, add JUST the path

lib/plugins/history/history.plugin.js

@@ -1,9 +1,6 @@
-var urls      = require("../../urls");
-var url       = require("url");
-var path      = require("path");
-var fs        = require("fs");
-var Immutable = require("immutable");
-var history   = require("./history");
+var path          = require("path");
+var fs            = require("fs");
+var historyPlugin = require("./history");
 
 const PLUGIN_NAME = "History";
 
@@ -16,7 +13,7 @@ module.exports = {
      * @param bs
      */
     "plugin": function (ui, bs) {
-        ui.history = history.init(ui, bs);
+        ui.history = historyPlugin.init(ui, bs);
     },
     /**
      * Hooks

lib/plugins/overview/overview.client.js

@@ -124,7 +124,7 @@
                     "options": "="
                 },
                 templateUrl: "snippet-info.html",
-                controller: ["$scope", function snippetInfoController($scope) {/*noop*/}]
+                controller: ["$scope", function snippetInfoController() {/*noop*/}]
             };
         });
 

lib/plugins/overview/overview.plugin.js

@@ -8,10 +8,9 @@ const PLUGIN_NAME = "Overview";
  */
 module.exports = {
     /**
-     * @param cp
-     * @param bs
+     * Plugin init
      */
-    "plugin": function (cp, bs) { /* noop */ },
+    "plugin": function () { /* noop */ },
 
     /**
      * Hooks

lib/plugins/remote-debug/latency.js

@@ -36,7 +36,7 @@ module.exports.init = function (ui, bs) {
             }
         },
         event: function (event) {
-            methods[event.event](event.data)
+            methods[event.event](event.data);
         }
     };
 

lib/plugins/remote-debug/remote-debug.plugin.js

@@ -1,8 +1,5 @@
-var urls           = require("../../urls");
-var url            = require("url");
 var path           = require("path");
 var fs             = require("fs");
-var Immutable      = require("immutable");
 var weinre         = require("./weinre");
 var latencyPlugin  = require("./latency");
 var clientFiles    = require("./client-files");
@@ -87,7 +84,7 @@ function throttleMiddleware () {
         setTimeout(function () {
             next();
         }, timeout);
-    }
+    };
 }
 
 module.exports.throttleMiddleware = throttleMiddleware;

lib/plugins/remote-debug/weinre.js

@@ -76,19 +76,6 @@ function setWeinreClientUrl(ui, weinreClientUrl) {
     });
 }
 
-/**
- * If it's snippet mode, create a url that contains host
- * @param targetPath
- * @param ui
- * @param bs
- */
-function getRemoteUrl(targetPath, ui, bs) {
-    if (bs.options.get("mode") === "snippet") {
-        return ["//", getHostUrl(ui, bs).host, targetPath].join("");
-    }
-    return targetPath;
-}
-
 /**
  * @param socket
  * @param clients
@@ -187,10 +174,9 @@ function enableWeinre (ui, bs) {
 
 /**
  * @param ui
- * @param bs
  * @returns {any|*}
  */
-function disableWeinre (ui, bs) {
+function disableWeinre (ui) {
     if (weinreApp) {
         weinreApp.close();
         weinreApp = false;

lib/server.js

@@ -54,7 +54,7 @@ function packageDir (path) {
  * @param opts
  * @returns {*}
  */
-function startServer(controlPanel, opts) {
+function startServer(controlPanel) {
 
     var connect     = controlPanel.bs.utils.connect;
     var serveStatic = controlPanel.bs.utils.serveStatic;

public/css/components.css

@@ -3,8 +3,7 @@ svg {
   height: 100%;
   opacity: 1;
   fill: currentColor !important;
-  -webkit-transition: .3s;
-          transition: .3s; }
+  transition: .3s; }
   svg.icon-hidden {
     opacity: 0; }