Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update libvpx to 1.3.1 #303

Merged
merged 1 commit into from
Oct 5, 2023
Merged

Update libvpx to 1.3.1 #303

merged 1 commit into from
Oct 5, 2023

Conversation

daniel-stanciu
Copy link
Contributor

@daniel-stanciu daniel-stanciu commented Oct 4, 2023

Libvpx should be updated to be more explicit in the fact it includes the security patch.

@BtbN
Copy link
Owner

BtbN commented Oct 4, 2023

libvpx already is updated for the security issues.
And on top of that, I'm pretty confident ffmpeg is not affected by it either way, since there is no way to reconfigure the amount of threads at runtime.

@daniel-stanciu
Copy link
Contributor Author

The main purpose of this PR was to avoid logs like [libvpx @ 0000028df60bd7c0] v1.13.0 which might give a naive user the impression that the fix is not included and could cause unwarranted skepticism.

@BtbN
Copy link
Owner

BtbN commented Oct 4, 2023

Yeah, that is fair. Will merge once all checks are green.

@daniel-stanciu
Copy link
Contributor Author

Yeah, that is fair. Will merge once all checks are green.

Something seems to have failed.

@daniel-stanciu
Copy link
Contributor Author

There seems to be a problem with the build machine
System.IO.IOException: No space left on device :

@BtbN
Copy link
Owner

BtbN commented Oct 4, 2023

This seems to be on Githubs end for all I can tell, there is no useful error output at all.

@daniel-stanciu
Copy link
Contributor Author

I would have tried a rerun, but I probably don't have permissions.

@BtbN
Copy link
Owner

BtbN commented Oct 4, 2023

I'm getting other weird issues with the builds right now. The registry randomly not finding an image it just pushed. I'll just try again in a few hours.

@BtbN
Copy link
Owner

BtbN commented Oct 4, 2023

Can you rebase this against master? I did a bunch of fixes, and it might work now.

Libvpx should be update to be more explicit in the fact it includes the security patch.
@daniel-stanciu
Copy link
Contributor Author

Rebased

@BtbN BtbN merged commit 115bdaa into BtbN:master Oct 5, 2023
36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants