perf(fock): Caching subspaces #249
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kolarovszki
force-pushed
the
kz-caching
branch
2 times, most recently
from
08b849e
to
1680979
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #249 +/- ##
==========================================
+ Coverage 96.55% 96.59% +0.04%
==========================================
Files 57 57
Lines 2928 2963 +35
==========================================
+ Hits 2827 2862 +35
Misses 101 101 ☔ View full report in Codecov by Sentry. |
Calculating the subspaces (the indices, essentially) is a costly calculation, and it is beneficial to have them stored in a cache for later purposes.
Kolarovszki
force-pushed
the
kz-caching
branch
from
1680979
to
9230d08
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Calculating the subspaces (the indices, essentially) is a costly calculation, and it is beneficial to have them stored in a cache for later purposes.