feat!(tensorflow): Refactor TensorflowPureFockSimulator
#260
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`TensorflowPureFockSimulator` has been deleted, and the option of specifying a calculator of type `BaseCalculator`, as a parameter of the simulator has been enabled. Moreover, a validation has been added to verify the provided calculator, since, e.g., currently `TensorflowCalculator` does not work with `GaussianSimulator` In fact, `TensorflowCalculator` is only supported by `PureFockSimulator` at this state. Tests have been rewritten accordingly.
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #260 +/- ##
=======================================
Coverage 96.96% 96.97%
=======================================
Files 60 58 -2
Lines 3132 3139 +7
=======================================
+ Hits 3037 3044 +7
Misses 95 95 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TensorflowPureFockSimulatorhas been deleted, and the option of specifying a calculator of typeBaseCalculator, as a parameter of the simulator has been enabled.Moreover, a validation has been added to verify the provided calculator, since, e.g., currently
TensorflowCalculatordoes not work withGaussianSimulatorIn fact,TensorflowCalculatoris only supported byPureFockSimulatorat this state.Tests have been rewritten accordingly.