feat(fock): Avoid matrix embedding #261
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In `FockSimulator`, the unitary matrices acting on the density operator were embedded in the Fock space, before directly multiplying with the density matrix. This can be done faster, by avoiding embedding and modifying only the relevant parts of the density matrix, as done in `PureFockSimulator` with the state vector instead of the density matrix. This approach has been implemented in this patch.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #261 +/- ##
==========================================
+ Coverage 96.97% 97.00% +0.02%
==========================================
Files 58 58
Lines 3139 3167 +28
==========================================
+ Hits 3044 3072 +28
Misses 95 95 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In
FockSimulator, the unitary matrices acting on the density operator were embedded in the Fock space, before directly multiplying with the density matrix. This can be done faster, by avoiding embedding and modifying only the relevant parts of the density matrix, as done inPureFockSimulatorwith the state vector instead of the density matrix. This approach has been implemented in this patch.