feat(tensorflow): Choose NumPy API in forward pass #265
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kolarovszki
force-pushed
the
kz-wip
branch
2 times, most recently
from
15e667f to
c50b540
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #265 +/- ##
==========================================
- Coverage 95.53% 95.43% -0.11%
==========================================
Files 59 59
Lines 3246 3283 +37
==========================================
+ Hits 3101 3133 +32
- Misses 145 150 +5 ☔ View full report in Codecov by Sentry. |
`tf.function` requires Piquasso to use Tensorflow's NumPy API in the forward pass. By default, we use regular NumPy for performance reasons, but this patch enables users to run Piquasso inside `tf.function`, which might be faster with JIT compilation enabled. Unfortunately, the JIT compilation is still very slow, and we may need to reduce the number of Python control flows during the calculation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tf.functionrequires Piquasso to use Tensorflow's NumPy API in the forward pass. By default, we use regular NumPy for performance reasons, but this patch enables users to run Piquasso insidetf.function, which might be faster with JIT compilation enabled.Unfortunately, the JIT compilation is still very slow, and we may need to reduce the number of Python control flows during the calculation.