fix!(fock): Rewrite PostSelectPhotons
#289
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is not really a fix, rather a rewrite: - `PostSelectPhotons` can be considered as a subclass of `Measurement`, because generally we cannot use the same `Simulator` for further simulations. - `PostSelectPhotons` should really be returning with the state on the remaining modes, it is not needed to keep the postselected photons in the ancilla mode.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #289 +/- ##
=======================================
Coverage 95.37% 95.38%
=======================================
Files 62 61 -1
Lines 3332 3336 +4
=======================================
+ Hits 3178 3182 +4
Misses 154 154 ☔ View full report in Codecov by Sentry. |
czaba7
approved these changes
Apr 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is not really a fix, rather a rewrite:
PostSelectPhotonscan be considered as a subclass ofMeasurement, because generally we cannot use the sameSimulatorfor further simulations.PostSelectPhotonsshould really be returning with the state on the remaining modes, it is not needed to keep the postselected photons in the ancilla mode.